chrome/chrome_browser.gypi - Issue 1150193004: Straighten up life cycle of native InfoBar pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed david's comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 5ff7380eaf642fc45b0ca60a91eb596cb88fd8c3..91b3197aac18c1706e61515ae4ed42d30c9f811d 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1725,6 +1725,7 @@

'android/java/src/org/chromium/chrome/browser/NavigationPopup.java',

'android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java',

'android/java/src/org/chromium/chrome/browser/infobar/DownloadOverwriteInfoBar.java',

+ 'android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java',

'android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java',

'android/java/src/org/chromium/chrome/browser/omnibox/AnswersImage.java',

'android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java',

@@ -1770,7 +1771,6 @@

'android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBarDelegate.java',

'android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java',

'android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java',

- 'android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBarDelegate.java',

'android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java',

'android/java/src/org/chromium/chrome/browser/invalidation/InvalidationServiceFactory.java',

'android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java',

« chrome/browser/ui/android/infobars/translate_infobar.cc ('K') | « chrome/browser/ui/android/infobars/translate_infobar.cc ('k') | no next file » | no next file with comments »