chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/OmahaUpdateInfobar.java - Issue 1150193004: Straighten up life cycle of native InfoBar pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/OmahaUpdateInfobar.java

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unrelated file Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBarDelegate.java ('k') | chrome/browser/ui/android/infobars/account_chooser_infobar.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/OmahaUpdateInfobar.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/OmahaUpdateInfobar.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/OmahaUpdateInfobar.java

index 46a5978fd32224874b1069a017e5e26dada4bd79..300e675ae7af3f0f259080fde1c855511c4a6048 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/OmahaUpdateInfobar.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/OmahaUpdateInfobar.java

@@ -34,10 +34,10 @@ public class OmahaUpdateInfobar extends ConfirmInfoBar {

private static final int ACTION_DISMISSED = 3;

private static final int ACTION_MAX = 3;

- private String mUrl;

- private Context mActivityContext;

+ private final String mUrl;

+ private final Context mActivityContext;

private boolean mActionTaken;

- private long mShownTime;

+ private final long mShownTime;

/**

* Listens for the InfoBar being dismissed and checks whether it was caused by a user action

@@ -65,8 +65,8 @@ public class OmahaUpdateInfobar extends ConfirmInfoBar {

public OmahaUpdateInfobar(Context activityContext, String message, String buttonMessage,

String url) {

- super(0, new DismissListener(), R.drawable.infobar_warning, null, message, null,

- buttonMessage, null);

+ super(new DismissListener(), R.drawable.infobar_warning, null, message, null, buttonMessage,

+ null);

mActivityContext = activityContext;

mUrl = url;

mShownTime = SystemClock.uptimeMillis();