Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2903)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed unrelated file Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java
index f566636df340dc8c9396cb28e40c99c3aa657c41..0476a2af1d93c39069de99cb8b367d1db620605d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java
@@ -45,9 +45,8 @@ public class AppBannerInfoBarAndroid extends ConfirmInfoBar implements View.OnCl
private final String mAppUrl;
// Banner for native apps.
- private AppBannerInfoBarAndroid(
- long nativeInfoBar, String appTitle, Bitmap iconBitmap, AppData data) {
- super(nativeInfoBar, null, 0, iconBitmap, appTitle, null, data.installButtonText(), null);
+ private AppBannerInfoBarAndroid(String appTitle, Bitmap iconBitmap, AppData data) {
+ super(null, 0, iconBitmap, appTitle, null, data.installButtonText(), null);
mAppTitle = appTitle;
mAppData = data;
mAppUrl = null;
@@ -55,9 +54,8 @@ public class AppBannerInfoBarAndroid extends ConfirmInfoBar implements View.OnCl
}
// Banner for web apps.
- private AppBannerInfoBarAndroid(
- long nativeInfoBar, String appTitle, Bitmap iconBitmap, String url) {
- super(nativeInfoBar, null, 0, iconBitmap, appTitle, null, getAddToHomescreenText(), null);
+ private AppBannerInfoBarAndroid(String appTitle, Bitmap iconBitmap, String url) {
+ super(null, 0, iconBitmap, appTitle, null, getAddToHomescreenText(), null);
mAppTitle = appTitle;
mAppData = null;
mAppUrl = url;
@@ -170,13 +168,12 @@ public class AppBannerInfoBarAndroid extends ConfirmInfoBar implements View.OnCl
@CalledByNative
private static InfoBar createNativeAppInfoBar(
- long nativeInfoBar, String appTitle, Bitmap iconBitmap, AppData appData) {
- return new AppBannerInfoBarAndroid(nativeInfoBar, appTitle, iconBitmap, appData);
+ String appTitle, Bitmap iconBitmap, AppData appData) {
+ return new AppBannerInfoBarAndroid(appTitle, iconBitmap, appData);
}
@CalledByNative
- private static InfoBar createWebAppInfoBar(
- long nativeInfoBar, String appTitle, Bitmap iconBitmap, String url) {
- return new AppBannerInfoBarAndroid(nativeInfoBar, appTitle, iconBitmap, url);
+ private static InfoBar createWebAppInfoBar(String appTitle, Bitmap iconBitmap, String url) {
+ return new AppBannerInfoBarAndroid(appTitle, iconBitmap, url);
}
}

Powered by Google App Engine
This is Rietveld 408576698