chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java - Issue 1150193004: Straighten up life cycle of native InfoBar pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unrelated file Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

index df8d40a47a9f0fd37d1faf7bb4ae6d3746817831..6f65835bc04a7c19641d004bd27ac7ba68e8a6d3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

@@ -248,7 +248,7 @@ public class ChromeDownloadDelegate

final String okButtonText = mContext.getResources().getString(R.string.ok);

final String cancelButtonText = mContext.getResources().getString(R.string.cancel);

- mTab.getInfoBarContainer().addInfoBar(new ConfirmInfoBar(0,

+ mTab.getInfoBarContainer().addInfoBar(new ConfirmInfoBar(

this, drawableId, null, titleText, null, okButtonText, cancelButtonText));

}

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java » ('j') | no next file with comments »