Removes calls to Widget::OnNativeWidgetActivationChanged() from

Removes calls to Widget::OnNativeWidgetActivationChanged() from
DNWA::OnActivated/OnLostActive. Widget::OnNativeWidgetActivationChanged()
should only be sent when active status of the RootWindowHost changes, not
the aura::Window. RootWindowHostWin/RootWindowHostLinux invoke
OnNativeWidgetActivationChanged() already, so the calls in DNWA can be
removed.

BUG=none
TEST=none
R=ben@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172115

[Ben Goodger (Google), 2012-12-10 17:46:54]

lgtm


On Mon, Dec 10, 2012 at 8:53 AM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Removes calls to Widget::**OnNativeWidgetActivationChange**d() from
> DNWA::OnActivated/**OnLostActive. Widget::**OnNativeWidgetActivationChange
> **d()
> should only be sent when active status of the RootWindowHost changes, not
> the aura::Window. RootWindowHostWin/**RootWindowHostLinux invoke
> OnNativeWidgetActivationChange**d() already, so the calls in DNWA can be
> removed.
>
> BUG=none
> TEST=none
> R=ben@chromium.org
>
>
> Please review this at
https://codereview.chromium.**org/11498014/<https://codereview.chromium.org/1...
>
> SVN Base:
http://git.chromium.org/**chromium/src.git@master<http://git.chromium.org/chr...
>
> Affected files:
>   M chrome/browser/ui/panels/**panel.cc
>   M ui/views/widget/desktop_aura/**desktop_native_widget_aura.cc
>
>
> Index: chrome/browser/ui/panels/**panel.cc
> diff --git a/chrome/browser/ui/panels/**panel.cc
> b/chrome/browser/ui/panels/**panel.cc
> index ffed912ee6ea93afd2e1ce31cfb2bd**799e9f20bf..**
> d0afc296ad3cb1ca311910e92ef089**34cf6cde6f 100644
> --- a/chrome/browser/ui/panels/**panel.cc
> +++ b/chrome/browser/ui/panels/**panel.cc
> @@ -409,7 +409,7 @@ void Panel::Show() {
>    if (manager()->display_settings_**provider()->is_full_screen() ||
> !collection_)
>      return;
>
> -    native_panel_->ShowPanel();
> +  native_panel_->ShowPanel();
>  }
>
>  void Panel::ShowInactive() {
> Index: ui/views/widget/desktop_aura/**desktop_native_widget_aura.cc
> diff --git a/ui/views/widget/desktop_**aura/desktop_native_widget_**aura.cc
> b/ui/views/widget/desktop_**aura/desktop_native_widget_**aura.cc
> index 0ac38a7959061a97a73ad7a604f5e9**0381cb55b5..**
> 9ebcc0cd05d8ec028ce4f754d94166**6a55468b1b 100644
> --- a/ui/views/widget/desktop_**aura/desktop_native_widget_**aura.cc
> +++ b/ui/views/widget/desktop_**aura/desktop_native_widget_**aura.cc
> @@ -619,13 +619,11 @@ bool DesktopNativeWidgetAura::**ShouldActivate()
> const {
>  }
>
>  void DesktopNativeWidgetAura::**OnActivated() {
> -  native_widget_delegate_->**OnNativeWidgetActivationChange**d(true);
>    if (IsVisible() && GetWidget()->non_client_view()**)
>      GetWidget()->non_client_view()**->SchedulePaint();
>  }
>
>  void DesktopNativeWidgetAura::**OnLostActive() {
> -  native_widget_delegate_->**OnNativeWidgetActivationChange**d(false);
>    if (IsVisible() && GetWidget()->non_client_view()**)
>      GetWidget()->non_client_view()**->SchedulePaint();
>  }
>
>
>

[commit-bot: I haz the power, 2012-12-10 18:01:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/11498014/1

[commit-bot: I haz the power, 2012-12-10 19:53:39]

Change committed as 172115