Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 11496010: PRESUBMIT #include check: don't add a warning if we're committing. (Closed)

Created:
8 years ago by marja
Modified:
8 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

PRESUBMIT #include check: don't add a warning if we're committing. This enables the commit queue to commit patches where the #include order is "wrong" according to the check. NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M PRESUBMIT.py View 1 chunk +7 lines, -2 lines 0 comments Download
M PRESUBMIT_test.py View 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
Re: e-mail discussion; I adapted the pattern used by _CheckNoProductionCodeUsingTestOnlyFunctions etc.
8 years ago (2012-12-10 14:20:18 UTC) #1
M-A Ruel
lgtm
8 years ago (2012-12-10 17:55:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/11496010/1
8 years ago (2012-12-10 17:55:41 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-10 17:55:54 UTC) #4
Message was sent while issue was closed.
Change committed as 172084

Powered by Google App Engine
This is Rietveld 408576698