Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 11496007: Fixed error screen behaviour when gaia frame loading is timed out. (Closed)

Created:
8 years ago by ygorshenin1
Modified:
8 years ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Fixed error screen behaviour when gaia frame loading is timed out. BUG=164720 TEST=manual tests on Lumpy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M chrome/browser/resources/chromeos/login/screen_error_message.js View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ygorshenin1
8 years ago (2012-12-10 12:52:09 UTC) #1
Nikita (slow)
lgtm executed trybots
8 years ago (2012-12-10 13:48:22 UTC) #2
Nikita (slow)
lgtm executed trybots
8 years ago (2012-12-10 13:48:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/11496007/1
8 years ago (2012-12-10 14:50:58 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-10 22:34:58 UTC) #5
Message was sent while issue was closed.
Change committed as 172157

Powered by Google App Engine
This is Rietveld 408576698