Issue 11491007: cc: Remove dangerous LayerImpl::removeFromParent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11491007: cc: Remove dangerous LayerImpl::removeFromParent (Closed)

Created:
8 years ago by enne (OOO)

Modified:
8 years ago

Reviewers:
danakj

CC:
chromium-reviews, cc-bugs_chromium.org, jamesr

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Remove dangerous LayerImpl::removeFromParent "delete this"-style functions considered harmful. R=danakj@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172019

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -16 lines)			Patch
M	cc/damage_tracker_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	cc/layer_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cc/layer_impl.cc	View	1 chunk	+9 lines, -14 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

danakj

LGTM and thanks https://codereview.chromium.org/11491007/diff/1/cc/layer_impl.cc File cc/layer_impl.cc (right): https://codereview.chromium.org/11491007/diff/1/cc/layer_impl.cc#newcode82 cc/layer_impl.cc:82: return ret.Pass(); nom nom, yay.

8 years ago (2012-12-09 23:35:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11491007/1

8 years ago (2012-12-09 23:41:43 UTC) #3

Message was sent while issue was closed.

Change committed as 172019

Expand Messages | Collapse Messages