Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: components/view_manager/view_manager_app.cc

Issue 1149083010: Mandoline: Remove native_viewport.mojom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More cleanup Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/view_manager/view_manager_app.cc
diff --git a/components/view_manager/view_manager_app.cc b/components/view_manager/view_manager_app.cc
index 75ffcde6a4a9e92ce3db3376ca8469046877a77c..a596e62f584b51cad7f700ccdde8762ce0e71fbb 100644
--- a/components/view_manager/view_manager_app.cc
+++ b/components/view_manager/view_manager_app.cc
@@ -8,7 +8,6 @@
#include "components/view_manager/client_connection.h"
#include "components/view_manager/connection_manager.h"
#include "components/view_manager/display_manager.h"
-#include "components/view_manager/native_viewport/native_viewport_impl.h"
#include "components/view_manager/public/cpp/args.h"
#include "components/view_manager/view_manager_service_impl.h"
#include "mojo/application/public/cpp/application_connection.h"
@@ -24,7 +23,6 @@ using mojo::ApplicationConnection;
using mojo::ApplicationImpl;
using mojo::Gpu;
using mojo::InterfaceRequest;
-using mojo::NativeViewport;
using mojo::ViewManagerRoot;
using mojo::ViewManagerService;
@@ -39,12 +37,6 @@ void ViewManagerApp::Initialize(ApplicationImpl* app) {
app_impl_ = app;
tracing_.Initialize(app);
- scoped_ptr<DefaultDisplayManager> display_manager(new DefaultDisplayManager(
- app_impl_, base::Bind(&ViewManagerApp::OnLostConnectionToWindowManager,
- base::Unretained(this))));
- connection_manager_.reset(
- new ConnectionManager(this, display_manager.Pass()));
-
#if !defined(OS_ANDROID)
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
is_headless_ = command_line->HasSwitch(mojo::kUseHeadlessConfig);
@@ -56,6 +48,16 @@ void ViewManagerApp::Initialize(ApplicationImpl* app) {
gfx::GLSurface::InitializeOneOff();
}
#endif
+
+ if (!gpu_state_.get())
+ gpu_state_ = new gles2::GpuState;
+ scoped_ptr<DefaultDisplayManager> display_manager(new DefaultDisplayManager(
+ app_impl_,
+ gpu_state_,
+ base::Bind(&ViewManagerApp::OnLostConnectionToWindowManager,
+ base::Unretained(this))));
+ connection_manager_.reset(
+ new ConnectionManager(this, display_manager.Pass()));
}
bool ViewManagerApp::ConfigureIncomingConnection(
@@ -65,7 +67,6 @@ bool ViewManagerApp::ConfigureIncomingConnection(
// to the ViewManager.
connection->AddService<ViewManagerService>(this);
connection->AddService<ViewManagerRoot>(this);
- connection->AddService<NativeViewport>(this);
connection->AddService<Gpu>(this);
return true;
@@ -141,18 +142,6 @@ void ViewManagerApp::Create(ApplicationConnection* connection,
void ViewManagerApp::Create(
mojo::ApplicationConnection* connection,
- mojo::InterfaceRequest<NativeViewport> request) {
- if (!gpu_state_.get())
- gpu_state_ = new gles2::GpuState;
- new native_viewport::NativeViewportImpl(
- is_headless_,
- gpu_state_,
- request.Pass(),
- app_impl_->app_lifetime_helper()->CreateAppRefCount());
-}
-
-void ViewManagerApp::Create(
- mojo::ApplicationConnection* connection,
mojo::InterfaceRequest<Gpu> request) {
if (!gpu_state_.get())
gpu_state_ = new gles2::GpuState;

Powered by Google App Engine
This is Rietveld 408576698