Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: components/view_manager/display_manager.h

Issue 1149083010: Mandoline: Remove native_viewport.mojom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More cleanup Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/view_manager/display_manager.h
diff --git a/components/view_manager/display_manager.h b/components/view_manager/display_manager.h
index 9bbeeca2a6d8e96c8678b9a5975c33bdad30c02b..5072306c96721a523bf5bc4c5fc5f7bf156c1316 100644
--- a/components/view_manager/display_manager.h
+++ b/components/view_manager/display_manager.h
@@ -11,19 +11,23 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/timer/timer.h"
+#include "components/view_manager/native_viewport/native_viewport.h"
#include "components/view_manager/public/interfaces/display.mojom.h"
-#include "components/view_manager/public/interfaces/native_viewport.mojom.h"
#include "components/view_manager/public/interfaces/view_manager.mojom.h"
#include "third_party/mojo/src/mojo/public/cpp/bindings/callback.h"
#include "ui/gfx/geometry/rect.h"
namespace cc {
class SurfaceIdAllocator;
-}
+} // namespace cc
+
+namespace gles2 {
+class GpuState;
+} // namespace gles2
namespace mojo {
class ApplicationImpl;
-}
+} // namespace mojo
namespace view_manager {
@@ -37,7 +41,7 @@ class DisplayManager {
virtual void Init(
ConnectionManager* connection_manager,
- mojo::NativeViewportEventDispatcherPtr event_dispatcher) = 0;
+ EventDispatcher* event_dispatcher) = 0;
// Schedules a paint for the specified region in the coordinates of |view|.
virtual void SchedulePaint(const ServerView* view,
@@ -55,12 +59,13 @@ class DefaultDisplayManager : public DisplayManager,
public:
DefaultDisplayManager(
mojo::ApplicationImpl* app_impl,
+ const scoped_refptr<gles2::GpuState>& gpu_state,
const mojo::Callback<void()>& native_viewport_closed_callback);
~DefaultDisplayManager() override;
// DisplayManager:
void Init(ConnectionManager* connection_manager,
- mojo::NativeViewportEventDispatcherPtr event_dispatcher) override;
+ EventDispatcher* event_dispatcher) override;
void SchedulePaint(const ServerView* view, const gfx::Rect& bounds) override;
void SetViewportSize(const gfx::Size& size) override;
const mojo::ViewportMetrics& GetViewportMetrics() override;
@@ -70,12 +75,13 @@ class DefaultDisplayManager : public DisplayManager,
void Draw();
void DidDraw();
- void OnMetricsChanged(mojo::ViewportMetricsPtr metrics);
+ void OnMetricsChanged(const gfx::Size& size, float device_scale_factor);
// ErrorHandler:
void OnConnectionError() override;
mojo::ApplicationImpl* app_impl_;
+ scoped_refptr<gles2::GpuState> gpu_state_;
ConnectionManager* connection_manager_;
mojo::ViewportMetrics metrics_;
@@ -84,8 +90,9 @@ class DefaultDisplayManager : public DisplayManager,
bool frame_pending_;
mojo::DisplayPtr display_;
- mojo::NativeViewportPtr native_viewport_;
+ scoped_ptr<NativeViewport> native_viewport_;
mojo::Callback<void()> native_viewport_closed_callback_;
+
base::WeakPtrFactory<DefaultDisplayManager> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(DefaultDisplayManager);

Powered by Google App Engine
This is Rietveld 408576698