Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: components/view_manager/native_viewport/platform_viewport_android.cc

Issue 1149083010: Mandoline: Remove native_viewport.mojom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Windows Build I hope Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/view_manager/native_viewport/platform_viewport_android.cc
diff --git a/components/view_manager/native_viewport/platform_viewport_android.cc b/components/view_manager/native_viewport/platform_viewport_android.cc
index ccca113fbce6631deebf12c52ac03e24e374d00f..f5d47be23d3ab45003180d295436b2b26ac290f8 100644
--- a/components/view_manager/native_viewport/platform_viewport_android.cc
+++ b/components/view_manager/native_viewport/platform_viewport_android.cc
@@ -8,6 +8,7 @@
#include <android/native_window_jni.h>
#include "base/android/jni_android.h"
+#include "components/view_manager/native_viewport/platform_viewport_headless.h"
#include "jni/PlatformViewportAndroid_jni.h"
#include "mojo/converters/geometry/geometry_type_converters.h"
#include "mojo/converters/input_events/input_events_type_converters.h"
@@ -98,12 +99,8 @@ void PlatformViewportAndroid::SurfaceSetSize(JNIEnv* env,
jint width,
jint height,
jfloat density) {
- metrics_ = mojo::ViewportMetrics::New();
- metrics_->size = mojo::Size::New();
- metrics_->size->width = static_cast<int>(width);
- metrics_->size->height = static_cast<int>(height);
- metrics_->device_pixel_ratio = density;
- delegate_->OnMetricsChanged(metrics_.Clone());
+ size_ = gfx::Size(static_cast<int>(width), static_cast<int>(height));
+ delegate_->OnMetricsChanged(size_, density);
}
bool PlatformViewportAndroid::TouchEvent(JNIEnv* env,
@@ -189,7 +186,7 @@ void PlatformViewportAndroid::Close() {
}
gfx::Size PlatformViewportAndroid::GetSize() {
- return metrics_->size.To<gfx::Size>();
+ return size_;
}
void PlatformViewportAndroid::SetBounds(const gfx::Rect& bounds) {
@@ -208,7 +205,11 @@ void PlatformViewportAndroid::ReleaseWindow() {
// PlatformViewport, public:
// static
-scoped_ptr<PlatformViewport> PlatformViewport::Create(Delegate* delegate) {
+scoped_ptr<PlatformViewport> PlatformViewport::Create(Delegate* delegate,
+ bool headless) {
+ if (headless)
+ return PlatformViewportHeadless::Create(delegate);
+
return scoped_ptr<PlatformViewport>(
new PlatformViewportAndroid(delegate)).Pass();
}

Powered by Google App Engine
This is Rietveld 408576698