Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 11488011: Rename NetworkChangeNotifierChromeos to NetworkChangeNotifierNetworkLibrary (Closed)

Created:
8 years ago by gauravsh
Modified:
8 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Rename NetworkChangeNotifierChromeos to NetworkChangeNotifierNetworkLibrary We are eventually deprecating this version of the network change notifier for Chrome OS in favor of a version that will use the new network state handler. This lets us avoid file and class name conflicts with the new version. BUG=chromium:162040 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172226

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : missed a few instances of NetworkChangeNotifierChromeos during rebase #

Patch Set 4 : 80 chars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -506 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/cros_network_change_notifier_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/net/cros_network_change_notifier_factory.cc View 1 chunk +5 lines, -4 lines 0 comments Download
D chrome/browser/chromeos/net/network_change_notifier_chromeos.h View 1 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/browser/chromeos/net/network_change_notifier_chromeos.cc View 1 1 chunk +0 lines, -350 lines 0 comments Download
A + chrome/browser/chromeos/net/network_change_notifier_network_library.h View 1 2 3 4 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/chromeos/net/network_change_notifier_network_library.cc View 1 2 3 15 chunks +31 lines, -29 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
gauravsh
8 years ago (2012-12-10 19:48:42 UTC) #1
stevenjb
lgtm
8 years ago (2012-12-10 20:10:54 UTC) #2
gauravsh
sky@: For chrome_browser_chromeos.gyp OWNERS review.
8 years ago (2012-12-10 20:53:53 UTC) #3
gauravsh
On 2012/12/10 20:53:53, gauravsh wrote: > sky@: For chrome_browser_chromeos.gyp OWNERS review.
8 years ago (2012-12-10 20:54:13 UTC) #4
Greg Spencer (Chromium)
lgtm
8 years ago (2012-12-10 22:20:41 UTC) #5
sky
LGTM - feel free to TBR these sort of changes to me.
8 years ago (2012-12-10 22:35:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/11488011/3002
8 years ago (2012-12-10 23:12:58 UTC) #7
commit-bot: I haz the power
Presubmit check for 11488011-3002 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-10 23:13:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/11488011/3003
8 years ago (2012-12-10 23:45:07 UTC) #9
commit-bot: I haz the power
8 years ago (2012-12-11 01:55:00 UTC) #10
Message was sent while issue was closed.
Change committed as 172226

Powered by Google App Engine
This is Rietveld 408576698