Issue 11488008: Adding more ONC validation tests.

Issue 11488008: Adding more ONC validation tests. (Closed)

Created:
8 years ago by pneubeck (no reviews)

Modified:
8 years ago

Reviewers:
Greg Spencer (Chromium), stevenjb, Mattias Nissler (ping if slow)

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@reject_network_independently

Visibility:
Public.

More Reviews

Description

Adding more ONC validation tests. - A typical configuration from real world. - A configuration generated from CPanel. BUG=162804 TBR=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173460

Patch Set 1 : Initial patch. #

Total comments: 2

Patch Set 2 : Rebased, addressed Mattias comment. #

Patch Set 3 : Rebased. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -57 lines)			Patch
M	chromeos/network/onc/onc_validator_unittest.cc	View	1 2	2 chunks	+18 lines, -1 line	0 comments	Download
M	chromeos/test/data/network/invalid_settings_with_repairs.json	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download
D	chromeos/test/data/network/managed_toplevel.onc	View	1	1 chunk	+0 lines, -47 lines	0 comments	Download
A +	chromeos/test/data/network/managed_toplevel1.onc	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chromeos/test/data/network/managed_toplevel2.onc	View	1	1 chunk	+90 lines, -0 lines	0 comments	Download
A	chromeos/test/data/network/managed_toplevel_cpanel.onc	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download
M	chromeos/test/data/network/shill_openvpn.json	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chromeos/test/data/network/valid_openvpn.onc	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

pneubeck (no reviews)

Adding more validation tests. (This CL is based on https://codereview.chromium.org/11428078/)

8 years ago (2012-12-10 14:56:18 UTC) #1

Mattias Nissler (ping if slow)

https://codereview.chromium.org/11488008/diff/8001/chrome/browser/chromeos/network_settings/onc_validator_unittest.cc File chrome/browser/chromeos/network_settings/onc_validator_unittest.cc (right): https://codereview.chromium.org/11488008/diff/8001/chrome/browser/chromeos/network_settings/onc_validator_unittest.cc#newcode248 chrome/browser/chromeos/network_settings/onc_validator_unittest.cc:248: // Strict and liberal validator repair but differently. ...

8 years ago (2012-12-13 09:51:46 UTC) #2

pneubeck (no reviews)

Rebased to Greg's latest CL. https://codereview.chromium.org/11488008/diff/8001/chrome/browser/chromeos/network_settings/onc_validator_unittest.cc File chrome/browser/chromeos/network_settings/onc_validator_unittest.cc (right): https://codereview.chromium.org/11488008/diff/8001/chrome/browser/chromeos/network_settings/onc_validator_unittest.cc#newcode248 chrome/browser/chromeos/network_settings/onc_validator_unittest.cc:248: // Strict and liberal ...

8 years ago (2012-12-13 14:33:02 UTC) #3

stevenjb

I'm going to rely on Greg and Mattias for this one - when it comes ...

8 years ago (2012-12-14 01:10:34 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/11488008/11002

8 years ago (2012-12-17 12:32:32 UTC) #6

commit-bot: I haz the power

Presubmit check for 11488008-11002 failed and returned exit status 1. Running presubmit commit checks ...

8 years ago (2012-12-17 12:32:41 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/11488008/11002

8 years ago (2012-12-17 12:34:06 UTC) #8

Message was sent while issue was closed.

Change committed as 173460

Expand Messages | Collapse Messages