Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2324)

Unified Diff: ash/metrics/task_switch_metrics_recorder.cc

Issue 1148723006: Added Ash.TimeBetweenTaskSwitches to record time deltas between all recorded task switches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated TaskSwitchMetricsRecorder documentation as per tdanderson@'s requests. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/metrics/task_switch_metrics_recorder.cc
diff --git a/ash/metrics/task_switch_metrics_recorder.cc b/ash/metrics/task_switch_metrics_recorder.cc
index b8b57fe4753606428c68f2be1236c100070d10c9..0d90cb3f2b7b556d03e68c14332368f1c992218a 100644
--- a/ash/metrics/task_switch_metrics_recorder.cc
+++ b/ash/metrics/task_switch_metrics_recorder.cc
@@ -10,6 +10,8 @@ namespace ash {
namespace {
+const char kAshTaskSwitchHistogramName[] = "Ash.TimeBetweenTaskSwitches";
+
const char kShelfHistogramName[] =
"Ash.Shelf.TimeBetweenNavigateToTaskSwitches";
@@ -28,6 +30,8 @@ const char kOverviewModeHistogramName[] =
const char* GetHistogramName(
TaskSwitchMetricsRecorder::TaskSwitchSource task_switch_source) {
switch (task_switch_source) {
+ case TaskSwitchMetricsRecorder::kAny:
+ return kAshTaskSwitchHistogramName;
case TaskSwitchMetricsRecorder::kAppList:
return kAppListHistogramName;
case TaskSwitchMetricsRecorder::kOverviewMode:
@@ -53,6 +57,15 @@ TaskSwitchMetricsRecorder::~TaskSwitchMetricsRecorder() {
void TaskSwitchMetricsRecorder::OnTaskSwitch(
TaskSwitchSource task_switch_source) {
+ DCHECK_NE(task_switch_source, kAny);
+ if (task_switch_source != kAny) {
+ OnTaskSwitchInternal(task_switch_source);
+ OnTaskSwitchInternal(kAny);
+ }
+}
+
+void TaskSwitchMetricsRecorder::OnTaskSwitchInternal(
+ TaskSwitchSource task_switch_source) {
TaskSwitchTimeTracker* task_switch_time_tracker =
FindTaskSwitchTimeTracker(task_switch_source);
if (!task_switch_time_tracker)

Powered by Google App Engine
This is Rietveld 408576698