Issue 11486007: Fix for when array bounds check elimination tries to modify a phi index.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11486007: Fix for when array bounds check elimination tries to modify a phi index. (Closed)

Created:
8 years ago by Massi

Modified:
8 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix for when array bounds check elimination tries to modify a phi index. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13193

Patch Set 1 #

Total comments: 3

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -21 lines)			Patch
	M	src/hydrogen.cc	View		7 chunks	+43 lines, -21 lines	3 comments	Download
	M	test/mjsunit/array-bounds-check-removal.js	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years ago (2012-12-11 13:42:15 UTC) #2

LGTM with nits.

I must say I'm surprised that there's not even a single for-loop in any of the
test cases. Don't most interesting array accesses happen inside loops?

https://chromiumcodereview.appspot.com/11486007/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/11486007/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:3542: return add->context();
nit: {}

https://chromiumcodereview.appspot.com/11486007/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:3544: return HBinaryOperation::cast(check->index())->context();
nit: {}

https://chromiumcodereview.appspot.com/11486007/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:3649: !data->CoverCheck(check, offset)) {
nit: please align:
    } else if (data->BasicBlock() != bb ||
               !data->CoverCheck(check, offset)) {

Expand Messages | Collapse Messages