Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 11486003: Fix CrOS compilation error due to lack of include of unistd.h. (Closed)

Created:
8 years ago by Pawel Osciak
Modified:
7 years, 9 months ago
Reviewers:
Nico, Ivan Korotkov
CC:
chromium-reviews, sail+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix CrOS compilation error due to lack of include of unistd.h. BUG=none TEST=manual build TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M rlz/lib/recursive_cross_process_lock_posix.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Pawel Osciak
8 years ago (2012-12-11 08:32:01 UTC) #1
Ivan Korotkov
LGTM Thanks for fixing!
8 years ago (2012-12-11 08:33:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/11486003/1
8 years ago (2012-12-11 08:34:31 UTC) #3
commit-bot: I haz the power
Presubmit check for 11486003-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-11 08:34:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/11486003/1
8 years ago (2012-12-11 08:37:07 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-11 11:10:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/11486003/1
8 years ago (2012-12-11 11:11:53 UTC) #7
commit-bot: I haz the power
Change committed as 172319
8 years ago (2012-12-11 13:54:04 UTC) #8
Nico
7 years, 9 months ago (2013-03-20 05:18:41 UTC) #9
Message was sent while issue was closed.
When you TBR something against me (or anyone), please add me to the reviewers
line and hit "publish+mail comments" so that I get an email about it. Include
"thakis: OWNERS for rlz/" or similar in the review message.

TBR= means "to be reviewed", not "submitted without review". If I don't know
about a change, I can't review it.

Powered by Google App Engine
This is Rietveld 408576698