chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc - Issue 11485022: Open bookmark in new background tab at Ctrl+Click but not closing menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

Issue 11485022: Open bookmark in new background tab at Ctrl+Click but not closing menu (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: 2012-12-12T10:27 Changes for review comments Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc b/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

index f0aacf20102f526d8275f811f0e728e66865f21b..b60b07926c5b27e9afe4195453a2096c4c63d1c0 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

@@ -101,6 +101,11 @@ void BookmarkMenuController::ExecuteCommand(int id, int mouse_event_flags) {

menu_delegate_->ExecuteCommand(id, mouse_event_flags);

}

+bool BookmarkMenuController::ShouldExecuteCommandWithoutClosingMenu(

+ int id, const ui::Event& e) {

+ return menu_delegate_->ShouldExecuteCommandWithoutClosingMenu(id, e);

bool BookmarkMenuController::GetDropFormats(

MenuItemView* menu,

int* formats,