Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h

Issue 11485022: Open bookmark in new background tab at Ctrl+Click but not closing menu (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: 2012-12-12T10:27 Changes for review comments Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_DELEGATE_H_
6 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_DELEGATE_H_ 6 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_DELEGATE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 10
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 90
91 // Returns true if we're in the process of mutating the model. This happens 91 // Returns true if we're in the process of mutating the model. This happens
92 // when the user deletes menu items using the context menu. 92 // when the user deletes menu items using the context menu.
93 bool is_mutating_model() const { return is_mutating_model_; } 93 bool is_mutating_model() const { return is_mutating_model_; }
94 94
95 // MenuDelegate like methods (see class description for details). 95 // MenuDelegate like methods (see class description for details).
96 string16 GetTooltipText(int id, const gfx::Point& p) const; 96 string16 GetTooltipText(int id, const gfx::Point& p) const;
97 bool IsTriggerableEvent(views::MenuItemView* menu, 97 bool IsTriggerableEvent(views::MenuItemView* menu,
98 const ui::Event& e); 98 const ui::Event& e);
99 void ExecuteCommand(int id, int mouse_event_flags); 99 void ExecuteCommand(int id, int mouse_event_flags);
100 bool ShouldExecuteCommandWithoutClosingMenu(int id, const ui::Event& e);
100 bool GetDropFormats( 101 bool GetDropFormats(
101 views::MenuItemView* menu, 102 views::MenuItemView* menu,
102 int* formats, 103 int* formats,
103 std::set<ui::OSExchangeData::CustomFormat>* custom_formats); 104 std::set<ui::OSExchangeData::CustomFormat>* custom_formats);
104 bool AreDropTypesRequired(views::MenuItemView* menu); 105 bool AreDropTypesRequired(views::MenuItemView* menu);
105 bool CanDrop(views::MenuItemView* menu, const ui::OSExchangeData& data); 106 bool CanDrop(views::MenuItemView* menu, const ui::OSExchangeData& data);
106 int GetDropOperation(views::MenuItemView* item, 107 int GetDropOperation(views::MenuItemView* item,
107 const ui::DropTargetEvent& event, 108 const ui::DropTargetEvent& event,
108 views::MenuDelegate::DropPosition* position); 109 views::MenuDelegate::DropPosition* position);
109 int OnPerformDrop(views::MenuItemView* menu, 110 int OnPerformDrop(views::MenuItemView* menu,
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 // Is the model being changed? 205 // Is the model being changed?
205 bool is_mutating_model_; 206 bool is_mutating_model_;
206 207
207 // The location where this bookmark menu will be displayed (for UMA). 208 // The location where this bookmark menu will be displayed (for UMA).
208 bookmark_utils::BookmarkLaunchLocation location_; 209 bookmark_utils::BookmarkLaunchLocation location_;
209 210
210 DISALLOW_COPY_AND_ASSIGN(BookmarkMenuDelegate); 211 DISALLOW_COPY_AND_ASSIGN(BookmarkMenuDelegate);
211 }; 212 };
212 213
213 #endif // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_DELEGATE_H_ 214 #endif // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698