Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 11485017: Disabling all breakpad unittests. (Closed)

Created:
8 years ago by aruslan
Modified:
8 years ago
Reviewers:
Yaron
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Disabling all breakpad unittests. Exact list of breakpad unit tests failing on official release: http://clankbotmaster:8120/builders/release-official-clankium/builds/224/steps/breakpad_unittests/logs/stdio FAILED=20 ['ExceptionHandlerTest.InstructionPointerMemory', 'ExceptionHandlerTest.InstructionPointerMemoryMinBound', 'ExceptionHandlerTest.InstructionPointerMemoryMaxBound', 'LinuxPtraceDumperTest.MergedMappings', 'LinuxPtraceDumperTest.VerifyStackReadWithMultipleThreads', 'MinidumpWriterTest.DeletedBinary', 'MinidumpWriterTest.MinidumpSizeLimit', 'ElfCoreDumpTest.TestElfHeader', 'ElfCoreDumpTest.ValidCoreFile', 'FileIDStripTest.StripSelf', 'FileIDStripTest.StripSelf', 'FileIDTest.UniqueHashes32', 'FileIDTest.ElfClass', 'FileIDTest.UniqueHashes64', 'FileIDTest.UniqueHashes32', 'LinuxLibcSupportTest.strtoui', 'FileIDTest.UniqueHashes64', 'PageAllocatorTest.SmallObjects', 'LinuxLibcSupportTest.read_decimal_ptr', 'gtest exit code: 1'] BUG=165355 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172274

Patch Set 1 #

Patch Set 2 : Disabling specific tests. Note the list in the bug has duplicates and gtest exit code. #

Patch Set 3 : Alphasort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
A build/android/gtest_filter/breakpad_unittests_disabled View 1 2 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aruslan
8 years ago (2012-12-11 02:40:24 UTC) #1
Yaron
lgtm
8 years ago (2012-12-11 02:56:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/11485017/3
8 years ago (2012-12-11 02:57:18 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-11 07:28:23 UTC) #4
Message was sent while issue was closed.
Change committed as 172274

Powered by Google App Engine
This is Rietveld 408576698