Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 11481004: explicitly validating assumptions about positive matrix scale (Closed)

Created:
8 years ago by whunt
Modified:
8 years ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

explicitly validating assumptions about positive matrix scale Due to my lack of git know-how this ended up being the entire clipping patch plus my last validation rather than just a few line fix. Given that the last one got reverted as a test anyway perhaps this is just as well? BUG=165237 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M cc/texture_draw_quad.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/texture_draw_quad.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M cc/texture_layer_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
lgtm on the patch The patch description appears to be citing the wrong bug - ...
8 years ago (2012-12-12 02:29:41 UTC) #1
whunt
8 years ago (2012-12-12 18:04:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/whunt@chromium.org/11481004/1
8 years ago (2012-12-12 18:05:25 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
8 years ago (2012-12-12 19:06:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/whunt@chromium.org/11481004/1
8 years ago (2012-12-12 19:13:02 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests, interactive_ui_tests
8 years ago (2012-12-12 20:27:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/whunt@chromium.org/11481004/1
8 years ago (2012-12-13 00:45:27 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-13 02:42:21 UTC) #8
Message was sent while issue was closed.
Change committed as 172788

Powered by Google App Engine
This is Rietveld 408576698