Chromium Code Reviews Chromium Code Reviews
Issue
11478039:
cc: Force layer tree tests to go idle before exiting. (Closed)
Descriptioncc: Force layer tree tests to go idle before exiting.
We've been plagued by flaky cc_unittests due to ending the test while the
scheduler still has work to do. This leaves us in a state where tests
sometimes run a pending commit, suddenly flaking.
This change forces test writers to clean up their tests properly, and not
schedule tasks that they don't intend for the test to include. The test will
not exit until the scheduler reports that it has no commit waiting to
process.
The LayerTreeHostTestCanDrawBlocksDrawing test caused problems as the
scheduler would end up in a weird state and never reach idle. I have
filed crbug.com/165022 for this test, but have worked around the bad
scheduler behaviour in this change.
R=enne,jamesr
BUG=148490
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173484
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173566
Patch Set 1 #Patch Set 2 : #Patch Set 3 : rebase #
Total comments: 2
Patch Set 4 : rebased #Patch Set 5 : #Patch Set 6 : #
Messages
Total messages: 8 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
