sdk/lib/_internal/compiler/implementation/ssa/codegen.dart - Issue 11478022: Implement is-checks with typedefs for callable objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 11478022: Implement is-checks with typedefs for callable objects. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

index b5e1a6b3b1f38ddd05eef974076bb840f938dbff..4689c823b813e2999a9821d85541d6386d0395e1 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

@@ -2355,15 +2355,13 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

if (identical(element.kind, ElementKind.TYPE_VARIABLE)) {

compiler.unimplemented("visitIs for type variables",

instruction: node.expression);

- } else if (identical(element.kind, ElementKind.TYPEDEF)) {

- compiler.unimplemented("visitIs for typedefs",

- instruction: node.expression);

}

LibraryElement coreLibrary = compiler.coreLibrary;

ClassElement objectClass = compiler.objectClass;

HInstruction input = node.expression;

- if (identical(element, objectClass) || identical(element, compiler.dynamicClass)) {

+ if (identical(element, objectClass) ||

+ identical(element, compiler.dynamicClass)) {

// The constant folder also does this optimization, but we make

// it safe by assuming it may have not run.

push(newLiteralBool(true), node);