Issue 11476031: Add the QuicRandom interface with a default implementation that is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11476031: Add the QuicRandom interface with a default implementation that is (Closed)

Created:
8 years ago by wtc

Modified:
8 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add the QuicRandom interface with a default implementation that is both cryptographically secure and thread-safe. The default QuicRandom is a singleton. crypto/random.h can include the smaller <stddef.h> for size_t. Add missing header files to net/net.gyp. R=rch@chromium.org BUG=none TEST=new unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171931

Patch Set 1 #

Total comments: 1

Patch Set 2 : Export QuicRandom for net_unittesrs #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -3 lines)			Patch
M	crypto/random.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/net.gyp	View		2 chunks	+7 lines, -2 lines	0 comments	Download
A	net/quic/crypto/quic_random.h	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
A	net/quic/crypto/quic_random.cc	View		1 chunk	+60 lines, -0 lines	0 comments	Download
A	net/quic/crypto/quic_random_test.cc	View		1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

https://codereview.chromium.org/11476031/diff/1/net/net.gyp File net/net.gyp (right): https://codereview.chromium.org/11476031/diff/1/net/net.gyp#newcode664 net/net.gyp:664: 'quic/crypto/null_decrypter.h', The missing headers do not break the build. ...

8 years ago (2012-12-07 20:23:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/11476031/4003

8 years ago (2012-12-07 23:31:14 UTC) #3

Message was sent while issue was closed.

Change committed as 171931

Expand Messages | Collapse Messages