Issue 11475054: cc: Add a blocksPendingCommit flag to LayerImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11475054: cc: Add a blocksPendingCommit flag to LayerImpl (Closed)

Created:
8 years ago by enne (OOO)

Modified:
8 years ago

Reviewers:
nduca

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

cc: Add a blocksPendingCommit flag to LayerImpl This can't get used yet until we have a pending->active tree commit, but I wanted to land the flag on layers first so that we could argue about the name. R=nduca@chromium.org BUG=164993 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171974

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
M	cc/layer.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	cc/layer.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	cc/texture_layer.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/texture_layer.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	cc/tiled_layer.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/tiled_layer.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

nduca

So I wonder, should we make this be a main-thread-side property? I dont think it ...

8 years ago (2012-12-08 04:12:21 UTC) #2

enne (OOO)

Ok, sure. Moved it main-thread side and named it blocksPendingCommit.

8 years ago (2012-12-08 05:14:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11475054/5001

8 years ago (2012-12-08 05:15:05 UTC) #5

Message was sent while issue was closed.

Change committed as 171974