Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 11475007: Exclude content/plugin/ when plugins are disabled. (Closed)

Created:
8 years ago by nilesh
Modified:
8 years ago
Reviewers:
brettw, Jay Civelli
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, markusheintz_, jam, palmer
Visibility:
Public.

Description

Exclude content/plugin/ when plugins are disabled. - Also exclude plugin_data_remover_impl from the build. BUG=162667 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -67 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 4 chunks +1 line, -14 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_plugin.gypi View 1 chunk +56 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nilesh
8 years ago (2012-12-06 21:46:42 UTC) #1
brettw
lgtm
8 years ago (2012-12-06 23:17:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/11475007/1
8 years ago (2012-12-07 01:58:27 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) media_unittests
8 years ago (2012-12-07 06:43:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/11475007/1
8 years ago (2012-12-07 07:11:48 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-07 09:17:00 UTC) #6
Message was sent while issue was closed.
Change committed as 171747

Powered by Google App Engine
This is Rietveld 408576698