Issue 11474037: Several updates to canPlayType() results for EME

Issue 11474037: Several updates to canPlayType() results for EME (Closed)

Created:
8 years ago by ddorwin

Modified:
8 years ago

Reviewers:
Charlie Reis, xhwang

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Several updates to canPlayType() results for EME 1) Disable audio codecs for Clear Key until decrypt-only is supported for audio (http://crbug.com/123421). 2) Manually support specific key system parents until http://crbug.com/164303 is fixed. 3) Report Widevine CENC support if available. TEST=new unit tests; manually running canPlayType() queries Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172175

Patch Set 1 #

Total comments: 6

Patch Set 2 : feedback #

Patch Set 3 : fix gcc build break #

Patch Set 4 : fix audio/mp4 for External Clear Key #

Patch Set 5 : rebase & gather parent keysystem support in one place #

Patch Set 6 : fix win build #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+699 lines, -4 lines)			Patch
M	content/content_tests.gypi	View	1 2 3 4	2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/media/crypto/key_systems.cc	View	1 2 3 4	4 chunks	+23 lines, -4 lines	0 comments	Download
A	webkit/media/crypto/key_systems_unittest.cc	View	1 2 3 4 5	1 chunk	+674 lines, -0 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

xhwang

lgtm % nits/comments https://codereview.chromium.org/11474037/diff/1/webkit/media/crypto/key_systems_unittest.cc File webkit/media/crypto/key_systems_unittest.cc (right): https://codereview.chromium.org/11474037/diff/1/webkit/media/crypto/key_systems_unittest.cc#newcode6 webkit/media/crypto/key_systems_unittest.cc:6: include vector and string https://codereview.chromium.org/11474037/diff/1/webkit/media/crypto/key_systems_unittest.cc#newcode64 webkit/media/crypto/key_systems_unittest.cc:64: ...

8 years ago (2012-12-07 22:35:39 UTC) #2

ddorwin

Thanks. PTAL. https://codereview.chromium.org/11474037/diff/1/webkit/media/crypto/key_systems_unittest.cc File webkit/media/crypto/key_systems_unittest.cc (right): https://codereview.chromium.org/11474037/diff/1/webkit/media/crypto/key_systems_unittest.cc#newcode6 webkit/media/crypto/key_systems_unittest.cc:6: On 2012/12/07 22:35:39, xhwang wrote: > include ...

8 years ago (2012-12-08 00:29:07 UTC) #3

ddorwin

creis, please do a quick OWNERS review of content/content_tests.gypi.

8 years ago (2012-12-08 01:05:52 UTC) #5

Charlie Reis

Rubber stamp LGTM (since I'm not familiar with that gypi syntax).

8 years ago (2012-12-08 01:50:27 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/11474037/12

8 years ago (2012-12-08 01:54:56 UTC) #7

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

8 years ago (2012-12-08 02:57:43 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/11474037/20001

8 years ago (2012-12-10 17:56:14 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/11474037/27003

8 years ago (2012-12-10 18:47:31 UTC) #10

Message was sent while issue was closed.

Change committed as 172175

Expand Messages | Collapse Messages