Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 11474014: Rename discardFramebufferEXT to discardBackbufferCHROMIUM to avoid collision with real discardFrame… (Closed)

Created:
8 years ago by jamesr
Modified:
8 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, apatrick_chromium, jonathan.backer, Ken Russell (switch to Gerrit), greggman
Visibility:
Public.

Description

Rename discardFramebufferEXT to discardBackbufferCHROMIUM to avoid collision with real discardFramebufferEXT Calling the (real) discardFramebufferEXT in the compositor is a performance win, at least on tilers. However currently it can't be called because we alias the name for a different API that controls backbuffer allocation, which I don't want to change. This renames the code to make backbuffer control a completely separate API so I can pipe GL_EXT_discard_framebuffer in fully as a follow-up. Depends on https://bugs.webkit.org/show_bug.cgi?id=104316 BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171908

Patch Set 1 #

Patch Set 2 : fix webgraphicscontext3d_command_buffer_impl.cc #

Patch Set 3 : back out accidental change to compositor_impl_android.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -53 lines) Patch
M cc/gl_renderer.h View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/gl_renderer.cc View 7 chunks +22 lines, -23 lines 0 comments Download
M cc/gl_renderer_unittest.cc View 1 8 chunks +18 lines, -18 lines 0 comments Download
M cc/layer_tree_host.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jamesr
8 years ago (2012-12-07 01:26:33 UTC) #1
piman
lgtm
8 years ago (2012-12-07 01:48:08 UTC) #2
Ken Russell (switch to Gerrit)
lgtm
8 years ago (2012-12-07 04:24:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11474014/1
8 years ago (2012-12-07 19:16:45 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-07 19:37:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11474014/3002
8 years ago (2012-12-07 22:02:23 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-08 01:29:42 UTC) #7
Message was sent while issue was closed.
Change committed as 171908

Powered by Google App Engine
This is Rietveld 408576698