Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 11474005: Current Serial port pattern in source cannot find proper port name. (Closed)

Created:
8 years ago by limasdf
Modified:
8 years ago
Reviewers:
miket_OOO
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Current Serial port pattern in source cannot find proper port name. That's because in Windows, Serial Port name has COM%d pattern. So I modified from old pattern \\\\.\\COM%d to COM%d Dear Miket, This file, serial_port_enumerator_win.cc has GenerateValidPatterns() function, but Your TODO comment says that you will not use valid_patterns. So, what is your method to solve this?, if allowed to use valid_patterns(like serial_port_enumerator_posix.cc), I'd like to do write code using valid_patterns. and I totally understand that your dev-environment doesn't include 'Windows OS'. so i like to help you contribute about Chrome Serial API in Windows. This issue is http://code.google.com/p/chromium/issues/detail?id=154803 BUG=154803 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172162

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_port_enumerator_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
miket_OOO
Thank you very much! I see you recently signed the CLA, so I'm going to ...
8 years ago (2012-12-10 19:25:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/11474005/3001
8 years ago (2012-12-10 19:32:57 UTC) #2
commit-bot: I haz the power
8 years ago (2012-12-10 22:43:19 UTC) #3
Message was sent while issue was closed.
Change committed as 172162

Powered by Google App Engine
This is Rietveld 408576698