Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 11473019: [cros,rlz] Remove RLZ checkbox from OOBE UI. (Closed)

Created:
8 years ago by Ivan Korotkov
Modified:
8 years ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, kkania, dyu1, arv (Not doing code reviews), robertshield, oshima+watch_chromium.org, dennis_jeffrey, anantha, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : linux_chromeos fix #

Patch Set 3 : Add back old strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -80 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/eula_screen.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/eula_screen.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/login/eula_screen_actor.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/mock_screen_observer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screen_observer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 4 chunks +4 lines, -19 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.css View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_eula.js View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc View 1 2 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ivan Korotkov
PTAL There's almost nothing RLZ-related here, only ChromeOS-related stuff
8 years ago (2012-12-07 12:58:55 UTC) #1
Nikita (slow)
I've executed cros_* bots
8 years ago (2012-12-07 13:04:15 UTC) #2
Nikita (slow)
lgtm
8 years ago (2012-12-07 13:06:26 UTC) #3
Ivan Korotkov
Adding TBR=nirnimesh@chromium.org for pyautolib changes
8 years ago (2012-12-10 09:07:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/11473019/8001
8 years ago (2012-12-10 09:07:23 UTC) #5
commit-bot: I haz the power
Change committed as 172040
8 years ago (2012-12-10 12:38:09 UTC) #6
dennis_jeffrey
8 years ago (2012-12-10 17:49:46 UTC) #7
Message was sent while issue was closed.
pyautolib changes LGTM

Powered by Google App Engine
This is Rietveld 408576698