Issue 11472023: Define CAN_USE_VFP2/3_INSTRUCTIONS based on arm_neon and arm_fpu flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11472023: Define CAN_USE_VFP2/3_INSTRUCTIONS based on arm_neon and arm_fpu flags. (Closed)

Created:
8 years ago by ulan

Modified:
8 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Define CAN_USE_VFP2/3_INSTRUCTIONS based on arm_neon and arm_fpu flags. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13175

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	build/common.gypi	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a nit. https://chromiumcodereview.appspot.com/11472023/diff/1/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/11472023/diff/1/build/common.gypi#newcode147 build/common.gypi:147: [ 'v8_can_use_vfp2_instructions=="true" or arm_neon==1 or ...

8 years ago (2012-12-07 15:03:45 UTC) #2

ulan

8 years ago (2012-12-07 15:08:54 UTC) #3

Landing.

https://chromiumcodereview.appspot.com/11472023/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/11472023/diff/1/build/common.gypi#newc...
build/common.gypi:147: [ 'v8_can_use_vfp2_instructions=="true" or arm_neon==1 or
arm_fpu=="vfpv3" or arm_fpu=="vfpv3-d16"', {
On 2012/12/07 15:03:45, Jakob wrote:
> nit: 80 columns please. You can use \ at the end of the line.
> 
> Again below.

Done.

Expand Messages | Collapse Messages

Issue 11472023: Define CAN_USE_VFP2/3_INSTRUCTIONS based on arm_neon and arm_fpu flags. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages