Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: vm/dart_api_impl.cc

Issue 11469036: - Create frame work for adding read only handles for symbols in the VM isolate (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | vm/flow_graph_builder.cc » ('j') | vm/parser.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/dart_api_impl.cc
===================================================================
--- vm/dart_api_impl.cc (revision 15861)
+++ vm/dart_api_impl.cc (working copy)
@@ -2745,8 +2745,7 @@
// Case 4. Lookup the function with a . appended to find the
// unnamed constructor.
if (func.IsNull()) {
- const String& dot = String::Handle(Symbols::Dot());
- tmp_name = String::Concat(func_name, dot);
+ tmp_name = String::Concat(func_name, Symbols::DotHandle());
func = cls.LookupFunction(tmp_name);
}
} else if (obj.IsLibrary()) {
@@ -3313,8 +3312,7 @@
if (name_obj.IsNull()) {
dot_name = Symbols::Dot();
} else if (name_obj.IsString()) {
- const String& dot = String::Handle(isolate, Symbols::Dot());
- dot_name = String::Concat(dot, String::Cast(name_obj));
+ dot_name = String::Concat(Symbols::DotHandle(), String::Cast(name_obj));
} else {
RETURN_TYPE_ERROR(isolate, constructor_name, String);
}
« no previous file with comments | « no previous file | vm/flow_graph_builder.cc » ('j') | vm/parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698