Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 11467020: cc: Only create tilings for layers that draws content. (Closed)

Created:
8 years ago by reveman
Modified:
8 years ago
Reviewers:
nduca, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Only create tilings for layers that draws content. BUG=164752 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171945

Patch Set 1 #

Patch Set 2 : Don't create tilings unless drawsContent() is true #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M cc/picture_layer_impl.cc View 1 1 chunk +10 lines, -6 lines 0 comments Download
M cc/picture_layer_tiling_set.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/picture_layer_tiling_set.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
reveman
We currently waste time posting raster tasks with empty picture piles. Looks like occlusion culling ...
8 years ago (2012-12-07 16:39:18 UTC) #1
enne (OOO)
Yeah, I agree that it would be better to not create these tiles in the ...
8 years ago (2012-12-07 17:37:29 UTC) #2
nduca
Sorry, where are these tiles from?
8 years ago (2012-12-07 17:47:06 UTC) #3
nduca
Enne sorted me out offline. They can do the final review. Ima good.
8 years ago (2012-12-07 18:18:26 UTC) #4
reveman
This seems to be enough. There might still be occlusion culling cases but I'd like ...
8 years ago (2012-12-07 23:54:54 UTC) #5
enne (OOO)
lgtm
8 years ago (2012-12-08 00:03:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/11467020/6001
8 years ago (2012-12-08 00:08:11 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-08 06:01:51 UTC) #8
Message was sent while issue was closed.
Change committed as 171945

Powered by Google App Engine
This is Rietveld 408576698