Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 11467016: Small patch to fix the "linux_redux" Chromium build. (Closed)

Created:
8 years ago by digit1
Modified:
8 years ago
Reviewers:
agl, Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Small patch to fix the "linux_redux" Chromium build. Trying to DEPS roll the previous patch, which updates the library to 1.0.1c, doesn't work for the following reason: - third_party/libjingle is now referencing DTLSv1_client_method and DTLSv1_server_method, which were missing from openssl.gyp (this affects both Android and linux_redux builds). - The piii/k8 configuration files didn't disable CAST5 and Whirlpool like the Android one, and the corresponding source files are missing from openssl.gyp. - The piii config now enables inline assembly, but the source repository is missing the assembly source for the ia32 OPENSSL_setup_cpuid() function. This patch is used to fix these issues in the most straightforward way. It is possible to address the issues by adding missing source files, but I'd rather do this in the upstream Android external/openssl tree first, to minimize the differences between them. BUG=137071 TEST=Passed net_unittests on both linux_redux and Android builds.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M config/k8/openssl/opensslconf.h View 2 chunks +9 lines, -0 lines 0 comments Download
M config/piii/openssl/opensslconf.h View 3 chunks +9 lines, -2 lines 0 comments Download
M openssl.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
digit1
Just to add a little bit of context, the previous DEPS roll failed, with details ...
8 years ago (2012-12-07 13:20:05 UTC) #1
agl
CAST5 only has significant use in OpenPGP as far as I'm aware, I think it's ...
8 years ago (2012-12-07 13:38:21 UTC) #2
digit1
Thank you Adam, it's always good to have an expert's advice :) anybody for a ...
8 years ago (2012-12-07 17:02:39 UTC) #3
Ryan Sleevi
Lgtm On Dec 7, 2012 9:02 AM, <digit@chromium.org> wrote: > Thank you Adam, it's always ...
8 years ago (2012-12-07 17:06:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/11467016/1
8 years ago (2012-12-07 17:10:43 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-07 17:10:52 UTC) #6
Message was sent while issue was closed.
Change committed as 171794

Powered by Google App Engine
This is Rietveld 408576698