Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 11466032: cc: Fix impl-side painting rasterization at >1 contents scales (Closed)

Created:
8 years ago by enne (OOO)
Modified:
8 years ago
CC:
chromium-reviews, cc-bugs_chromium.org, nduca
Visibility:
Public.

Description

cc: Fix impl-side painting rasterization at >1 contents scales Previously there was a content space vs. layer space mixup. cc::Tile had a member variable that was labeled rect_in_layer_space, but the tilings were making a content space rect. It's actually impossible to have an int rect in layer space for most content spaces, so this got renamed to just be content_space rect. The actual bug was that this rect was being used to check if a given picture's layer rect intersected it, so as soon as you got over bounds() / content_scale away from the origin, the tile was getting nothing rastered to it and whatever memory was in the canvas was being used, which happened to be old tiles. R=aelias@chromium.org BUG=164750 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M cc/picture.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/picture_pile_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/picture_pile_impl.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M cc/tile.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/tile.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/tile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
enne (OOO)
8 years ago (2012-12-08 00:53:01 UTC) #1
nduca
omg lgtm
8 years ago (2012-12-08 00:55:45 UTC) #2
aelias_OOO_until_Jul13
lgtm
8 years ago (2012-12-08 01:14:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11466032/1
8 years ago (2012-12-08 01:37:05 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-08 08:48:22 UTC) #5
Message was sent while issue was closed.
Change committed as 171964

Powered by Google App Engine
This is Rietveld 408576698