Set defaults for building chrome for linux/arm.

Set defaults for building chrome for linux/arm.

Previously many custom GYP_DEFINES were needed to get a
chrome build for linux/arm.  This adds these as sensible
defaults. This allows chrome for arm to be built with
with only target_arch=arm set in GYP_DEFINES.

In order to set a default sysroot based on target_arch
this change also defines target_arch one level deeper
in common.gypi.


BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172377

[iannucci, 2012-12-07 23:54:06]

https://chromiumcodereview.appspot.com/11465030/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/11465030/diff/1/build/common.gypi#newc...
build/common.gypi:587: ['OS=="linux"', { # and target_arch=="arm" and
chromeos==0', {
I'm not sure I'm reading this right, but it looks like this is really just
'OS=="linux"' with a comment after it?

[Sam Clegg, 2012-12-08 00:03:12]

https://chromiumcodereview.appspot.com/11465030/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/11465030/diff/1/build/common.gypi#newc...
build/common.gypi:587: ['OS=="linux"', { # and target_arch=="arm" and
chromeos==0', {
On 2012/12/07 23:54:06, iannucci wrote:
> I'm not sure I'm reading this right, but it looks like this is really just
> 'OS=="linux"' with a comment after it?

Great catch. Thank you.

Done.

Do you happen to know if chromos builds with OS=linux and chromeos=1?

[iannucci, 2012-12-08 00:27:11]

On 2012/12/08 00:03:12, Sam Clegg wrote:
> https://chromiumcodereview.appspot.com/11465030/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
>
https://chromiumcodereview.appspot.com/11465030/diff/1/build/common.gypi#newc...
> build/common.gypi:587: ['OS=="linux"', { # and target_arch=="arm" and
> chromeos==0', {
> On 2012/12/07 23:54:06, iannucci wrote:
> > I'm not sure I'm reading this right, but it looks like this is really just
> > 'OS=="linux"' with a comment after it?
> 
> Great catch. Thank you.
> 
> Done.
> 
> Do you happen to know if chromos builds with OS=linux and chromeos=1?

Good question. It looks like the answer is yes:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

OS gets set by gyp automagically.

[iannucci, 2012-12-08 00:34:22]

lgtm

[commit-bot: I haz the power, 2012-12-10 06:16:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11465030/6001

[commit-bot: I haz the power, 2012-12-10 06:16:06]

Failed to apply patch for build/common.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/common.gypi
  Hunk #1 succeeded at 588 (offset 5 lines).
  Hunk #2 succeeded at 1231 (offset 7 lines).
  Hunk #3 FAILED at 2812.
  1 out of 3 hunks FAILED -- saving rejects to file build/common.gypi.rej

Patch:       build/common.gypi
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index
2ec42a280325d643b98fd051adcb71862f6d0189..53452224b18c5f596d0cccc962e936a56aa98c97
100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -583,6 +583,16 @@
         }, {
           'enable_settings_app%': 0,
         }],
+
+        ['OS=="linux" and target_arch=="arm" and chromeos==0', {
+          # Set some defaults for arm/linux chrome builds
+          'armv7%': 1,
+          'linux_breakpad%': 0,
+          'linux_use_tcmalloc%': 0,
+          # sysroot need to be an absolute path otherwise it generates
+          # incorrect results when passed to pkg-config
+          'sysroot%': '<!(cd <(DEPTH)/arm-sysroot && pwd -P)',
+        }], # OS=="linux" and target_arch=="arm"
       ],
 
       # Set this to 1 to use the Google-internal file containing
@@ -1214,7 +1224,6 @@
           }],
         ],
       }],  # OS=="mac"
-
       ['OS=="win"', {
         'conditions': [
           ['component=="shared_library"', {
@@ -2803,7 +2812,7 @@
               # Don't enable multi-threaded linking for 32-bit targets as it
               # causes intermittent crashed on lucid32: http://crbug.com/161942
               # TODO(sbc): remove this once gold bug is fixed
-              ['host_arch!="ia32"', {
+              ['host_arch!="ia32" and host_arch!="arm"', {
                 'ldflags': [
                   # Experimentation found that using four linking threads
                   # saved ~20% of link time.

[commit-bot: I haz the power, 2012-12-10 22:50:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11465030/17002

[commit-bot: I haz the power, 2012-12-10 23:02:11]

Retried try job too often on linux_chromeos for step(s) aura_unittests,
base_unittests, browser_tests, cacheinvalidation_unittests, check_deps,
chromeos_unittests, content_browsertests, content_unittests, crypto_unittests,
dbus_unittests, device_unittests, gpu_unittests, interactive_ui_tests,
ipc_tests, jingle_unittests, media_unittests, net_unittests, ppapi_unittests,
printing_unittests, sandbox_linux_unittests, sql_unittests, sync_unit_tests,
unit_tests

[commit-bot: I haz the power, 2012-12-11 00:02:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11465030/22006

[Sam Clegg, 2012-12-11 02:40:23]

+brad so he can approve the crazy gyp variable nesting
stuff.  I had to push the definition of target_arch one
level deeper in order to be able to use it in the 
conditional setting of sysroot.

PTAL

[bradn, 2012-12-11 17:04:01]

LGTM, sigh....gyp

[commit-bot: I haz the power, 2012-12-11 17:51:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11465030/22008

[iannucci, 2012-12-11 17:55:59]

On 2012/12/11 17:04:01, bradn wrote:
> LGTM, sigh....gyp

Heh... seriously :D. It's a love/hate thing for sure (though imagine if we used
checked-in makefiles or msvs projects O_o)

sbc: BTW, I pushed the commit button :)

[commit-bot: I haz the power, 2012-12-11 19:49:23]

Change committed as 172377