Chromium Code Reviews
Help | Chromium Project | Sign in
(1170)

Issue 11465028: rename web_components -> web_ui (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by John Messerly
Modified:
1 year, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/web-ui.git@master
Visibility:
Public.

Description

rename web_components -> web_ui

Committed: https://github.com/dart-lang/dart-web-components/commit/f861c49

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -711 lines) Lint Patch
M bin/dwc.dart View 1 chunk +1 line, -1 line 0 comments ? errors Download
M bin/dwc_browser.dart View 1 chunk +7 lines, -7 lines 0 comments ? errors Download
M build.dart View 1 chunk +1 line, -1 line 0 comments ? errors Download
M example/explainer/build_examples.dart View 1 chunk +1 line, -1 line 0 comments ? errors Download
M example/explainer/countcomponent.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M example/explainer/countcomponent5.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M example/explainer/counter.html View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M example/no_wrapper_fu/components/component_loader.dart View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M example/todomvc/editable_label.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M example/todomvc/main.dart View 1 chunk +1 line, -1 line 0 comments ? errors Download
M example/todomvc/router_options.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M example/todomvc/todo_row.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M lib/component_build.dart View 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M lib/src/codegen.dart View 1 chunk +1 line, -1 line 0 comments ? errors Download
M lib/src/file_system/browser.dart View 1 chunk +1 line, -1 line 0 comments ? errors Download
M lib/src/file_system/console.dart View 1 chunk +1 line, -1 line 0 comments ? errors Download
M lib/src/utils.dart View 1 chunk +1 line, -1 line 0 comments ? errors Download
M lib/templating.dart View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
D lib/web_components.dart View 1 chunk +0 lines, -583 lines 0 comments ? errors Download
A + lib/web_ui.dart View 1 chunk +1 line, -1 line 0 comments ? errors Download
M pubspec.yaml View 1 chunk +4 lines, -4 lines 2 comments ? errors Download
M test/analyzer_test.dart View 1 chunk +6 lines, -6 lines 0 comments ? errors Download
M test/compiler_test.dart View 1 chunk +4 lines, -4 lines 0 comments ? errors Download
M test/data/input/attr_multiple_bindings_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/code_in_dart_file_component.dart View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/component_field_2way_test.html View 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M test/data/input/component_field_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/component_in_main_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/component_inherit_noscript_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/component_inherit_test.html View 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M test/data/input/component_unique_ids_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/component_with_event_listeners.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/conditional2_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/conditional3_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/conditional4_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/conditional5_component.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/conditional5_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/css_classes_binding_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/custom_radio_button_test.html View 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M test/data/input/data_style_binding_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/dom_accessor_binding2_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/dom_accessor_binding_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/ensure_parent_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/escape2_test.html View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M test/data/input/escape_test.html View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M test/data/input/escape_uri_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/html_escape_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/if_attribute_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/if_fragments2_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/iterate_attribute_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/list2_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/list3_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/list4_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/list5_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/list6_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/list_component.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/main_code_in_dart_file.dart View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/mix_iterate_if_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/path_normalization_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/radio_button_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/root_query_no_shadowroot_test.html View 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M test/data/input/table_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/text_multiple_bindings_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/text_top_level2_test.html View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M test/data/input/text_top_level_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/text_tostring_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/todomvc_listorder_shadowdom_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/todomvc_listorder_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/todomvc_mainpage2_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/todomvc_mainpage_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/todomvc_markdone_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/watch_global_var2_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/watch_global_var_component.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/data/input/watch_global_var_test.html View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/directive_parser_test.dart View 1 chunk +3 lines, -3 lines 0 comments ? errors Download
M test/emitter_test.dart View 1 chunk +5 lines, -5 lines 0 comments ? errors Download
M test/html5_utils_test.dart View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M test/html_cleaner_test.dart View 1 chunk +4 lines, -4 lines 0 comments ? errors Download
M test/path_info_test.dart View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M test/run_all.dart View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/testing.dart View 1 chunk +7 lines, -7 lines 0 comments ? errors Download
M test/utils_test.dart View 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/watcher_test.dart View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 4
John Messerly
1 year, 4 months ago #1
Siggi Cherem (dart-lang)
https://chromiumcodereview.appspot.com/11465028/diff/1/pubspec.yaml File pubspec.yaml (right): https://chromiumcodereview.appspot.com/11465028/diff/1/pubspec.yaml#newcode5 pubspec.yaml:5: version: 0.2.9 maybe don't bump the version just yet, ...
1 year, 4 months ago #2
Siggi Cherem (dart-lang)
(and lgtm)
1 year, 4 months ago #3
John Messerly
1 year, 4 months ago #4
https://chromiumcodereview.appspot.com/11465028/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://chromiumcodereview.appspot.com/11465028/diff/1/pubspec.yaml#newcode5
pubspec.yaml:5: version: 0.2.9
On 2012/12/07 21:34:29, Siggi Cherem (dart-lang) wrote:
> maybe don't bump the version just yet, since we are not uploading to pub until
> after I merge the changes for the new trunk?

sure. sgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6