Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: chrome/browser/media/midi_permission_context_unittest.cc

Issue 1146403004: MidiPermissionContext::GetPermission() returns BLOCK for insecure origins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/midi_permission_context.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/midi_permission_context_unittest.cc
diff --git a/chrome/browser/media/midi_permission_context_unittest.cc b/chrome/browser/media/midi_permission_context_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b5237ebf54bcd1b403f1eef5cadf0a1413a81196
--- /dev/null
+++ b/chrome/browser/media/midi_permission_context_unittest.cc
@@ -0,0 +1,136 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/media/midi_permission_context.h"
+
+#include "base/bind.h"
+#include "chrome/browser/content_settings/permission_queue_controller.h"
+#include "chrome/browser/infobars/infobar_service.h"
+#include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
+#include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "chrome/test/base/testing_profile.h"
+#include "components/content_settings/core/browser/host_content_settings_map.h"
+#include "components/content_settings/core/common/content_settings.h"
+#include "components/content_settings/core/common/content_settings_types.h"
+#include "components/content_settings/core/common/permission_request_id.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/test/mock_render_process_host.h"
+#include "content/public/test/web_contents_tester.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+class TestPermissionContext : public MidiPermissionContext {
+ public:
+ explicit TestPermissionContext(Profile* profile)
+ : MidiPermissionContext(profile),
+ permission_set_(false),
+ permission_granted_(false),
+ tab_context_updated_(false) {}
+
+ ~TestPermissionContext() override {}
+
+ PermissionQueueController* GetInfoBarController() {
+ return GetQueueController();
+ }
+
+ bool permission_granted() {
+ return permission_granted_;
+ }
+
+ bool permission_set() {
+ return permission_set_;
+ }
+
+ bool tab_context_updated() {
+ return tab_context_updated_;
+ }
+
+ void TrackPermissionDecision(ContentSetting content_setting) {
+ permission_set_ = true;
+ permission_granted_ = content_setting == CONTENT_SETTING_ALLOW;
+ }
+
+ protected:
+ void UpdateTabContext(const PermissionRequestID& id,
+ const GURL& requesting_origin,
+ bool allowed) override {
+ tab_context_updated_ = true;
+ }
+
+ private:
+ bool permission_set_;
+ bool permission_granted_;
+ bool tab_context_updated_;
+};
+
+} // anonymous namespace
+
+class MidiPermissionContextTests : public ChromeRenderViewHostTestHarness {
+ protected:
+ MidiPermissionContextTests() = default;
+
+ private:
+ // ChromeRenderViewHostTestHarness:
+ void SetUp() override {
+ ChromeRenderViewHostTestHarness::SetUp();
+ InfoBarService::CreateForWebContents(web_contents());
+ PermissionBubbleManager::CreateForWebContents(web_contents());
+ }
+
+ DISALLOW_COPY_AND_ASSIGN(MidiPermissionContextTests);
+};
+
+// Web MIDI permission should be denied for insecure origin.
+TEST_F(MidiPermissionContextTests, TestInsecureRequestingUrl) {
+ TestPermissionContext permission_context(profile());
+ GURL url("http://www.example.com");
+ content::WebContentsTester::For(web_contents())->NavigateAndCommit(url);
+
+ const PermissionRequestID id(
+ web_contents()->GetRenderProcessHost()->GetID(),
+ web_contents()->GetRenderViewHost()->GetRoutingID(),
+ -1, GURL());
+ permission_context.RequestPermission(
+ web_contents(),
+ id, url, true,
+ base::Bind(&TestPermissionContext::TrackPermissionDecision,
+ base::Unretained(&permission_context)));
+
+ EXPECT_TRUE(permission_context.permission_set());
+ EXPECT_FALSE(permission_context.permission_granted());
+ EXPECT_TRUE(permission_context.tab_context_updated());
+
+ ContentSetting setting =
+ profile()->GetHostContentSettingsMap()->GetContentSetting(
+ url.GetOrigin(), url.GetOrigin(),
+ CONTENT_SETTINGS_TYPE_MIDI_SYSEX, std::string());
+ EXPECT_EQ(CONTENT_SETTING_ASK, setting);
+}
+
+// Web MIDI permission status should be denied for insecure origin.
+TEST_F(MidiPermissionContextTests, TestInsecureQueryingUrl) {
+ TestPermissionContext permission_context(profile());
+ GURL insecure_url("http://www.example.com");
+ GURL secure_url("https://www.example.com");
+
+ // Check that there is no saved content settings.
+ EXPECT_EQ(CONTENT_SETTING_ASK,
+ profile()->GetHostContentSettingsMap()->GetContentSetting(
+ insecure_url.GetOrigin(), insecure_url.GetOrigin(),
+ CONTENT_SETTINGS_TYPE_MIDI_SYSEX, std::string()));
+ EXPECT_EQ(CONTENT_SETTING_ASK,
+ profile()->GetHostContentSettingsMap()->GetContentSetting(
+ secure_url.GetOrigin(), insecure_url.GetOrigin(),
+ CONTENT_SETTINGS_TYPE_MIDI_SYSEX, std::string()));
+ EXPECT_EQ(CONTENT_SETTING_ASK,
+ profile()->GetHostContentSettingsMap()->GetContentSetting(
+ insecure_url.GetOrigin(), secure_url.GetOrigin(),
+ CONTENT_SETTINGS_TYPE_MIDI_SYSEX, std::string()));
+
+ EXPECT_EQ(CONTENT_SETTING_BLOCK, permission_context.GetPermissionStatus(
+ insecure_url, insecure_url));
+ EXPECT_EQ(CONTENT_SETTING_BLOCK, permission_context.GetPermissionStatus(
+ insecure_url, secure_url));
ddorwin 2015/05/26 17:23:50 Isn't this impossible (secure embedding insecure)?
mlamouri (slow - plz ping) 2015/05/28 13:10:22 It's possible. Also, the opposite wouldn't be usef
+}
« no previous file with comments | « chrome/browser/media/midi_permission_context.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698