Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 11464012: [Android] Add support for labeling a build with a particular build id. (Closed)

Created:
8 years ago by Yaron
Modified:
8 years ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[Android] Add support for labeling a build with a particular build id. The build id will be included in about:version page and used for tracking build artifacts such as static libraries and symbol files with a particular build. BUG=163224 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172296

Patch Set 1 #

Total comments: 1

Patch Set 2 : indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -17 lines) Patch
M build/common.gypi View 1 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/app/breakpad_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/about_version.html View 1 1 chunk +14 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Yaron
mark: build/common and chrome/app estade: chrome/browser
8 years ago (2012-12-06 23:25:31 UTC) #1
Mark Mentovai
LGTM
8 years ago (2012-12-07 14:46:52 UTC) #2
Evan Stade
lgtm https://codereview.chromium.org/11464012/diff/1/chrome/browser/resources/about_version.html File chrome/browser/resources/about_version.html (right): https://codereview.chromium.org/11464012/diff/1/chrome/browser/resources/about_version.html#newcode98 chrome/browser/resources/about_version.html:98: <td class="label" i18n-content="build_id_name"></td> 2 fewer spaces of indent ...
8 years ago (2012-12-10 20:41:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11464012/7001
8 years ago (2012-12-10 21:39:13 UTC) #4
commit-bot: I haz the power
Presubmit check for 11464012-7001 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-10 21:39:42 UTC) #5
Yaron
+cpu for chrome/app OWNERS
8 years ago (2012-12-10 21:41:34 UTC) #6
cpu_(ooo_6.6-7.5)
rubber stamp lgtm
8 years ago (2012-12-11 04:12:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11464012/7001
8 years ago (2012-12-11 07:40:27 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-11 10:36:19 UTC) #9
Message was sent while issue was closed.
Change committed as 172296

Powered by Google App Engine
This is Rietveld 408576698