Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 11451005: Fix spec violations related to regexp.lastIndex (Closed)

Created:
8 years ago by Yang
Modified:
8 years ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Fix spec violations related to regexp.lastIndex BUG=v8:2437, v8:2438 Committed: https://code.google.com/p/v8/source/detail?r=13143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -56 lines) Patch
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/regexp.js View 3 chunks +6 lines, -2 lines 0 comments Download
M src/runtime.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M src/string.js View 3 chunks +10 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-2437.js View 1 chunk +40 lines, -22 lines 0 comments Download
A + test/mjsunit/regress/regress-2438.js View 1 chunk +22 lines, -27 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
PTAL. This does not cause any failures on WebKit layout tests and Test262.
8 years ago (2012-12-05 10:35:24 UTC) #1
rossberg
8 years ago (2012-12-05 12:04:20 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698