Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: bin/dwc_browser.dart

Issue 11450020: (Fix #215) better error printing in editor & extension, adds mapping for editor (Closed) Base URL: git@github.com:dart-lang/dart-web-components.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extension/background.js » ('j') | lib/src/messages.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/dwc_browser.dart
diff --git a/bin/dwc_browser.dart b/bin/dwc_browser.dart
index 157a0591fa0f8dbf15c8c6a054712c4caba0c720..879de8971a947f8cbbbc2d99bfe32413c571c9a4 100644
--- a/bin/dwc_browser.dart
+++ b/bin/dwc_browser.dart
@@ -42,7 +42,7 @@ void parse(js.Proxy sourcePagePort, String sourceUri) {
fileSystem = new BrowserFileSystem(uri.scheme, sourcePagePort);
// TODO(jacobr): provide a way to pass in options.
var options = CompilerOptions.parse(['--no-colors', uri.path]);
- messages = new Messages(options: options);
+ messages = new Messages(options: options, shouldPrint: false);
asyncTime('Compiled $sourceUri', () {
var compiler = new Compiler(fileSystem, options);
return compiler.run().chain((_) {
@@ -50,6 +50,11 @@ void parse(js.Proxy sourcePagePort, String sourceUri) {
fileSystem.writeString(file.path, file.contents);
}
var ret = fileSystem.flush();
+ js.scoped(() {
+ js.context.proxyMessages(sourcePagePort,
+ js.array(messages.messages.map(
+ (m) => [m.level.name, m.toString()])));
+ });
js.release(sourcePagePort);
return ret;
});
« no previous file with comments | « no previous file | extension/background.js » ('j') | lib/src/messages.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698