Add a presubmit check to prevent committing .rej/.orig patch files

Add a presubmit check to prevent committing .rej/.orig patch files

This is a follow-up to me having to remove some of these by hand in r171143.

R=maruel@chromium.org
NOTRY=true
BUG=none


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171287

[M-A Ruel, 2012-12-05 19:30:17]

https://codereview.chromium.org/11448014/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/11448014/diff/1/PRESUBMIT.py#newcode779
PRESUBMIT.py:779: if_patch_file.match(f.LocalPath())]
if f.LocalPath().endswith(('.orig', '.rej'))
is cleaned to me.
Also align at +4.

https://codereview.chromium.org/11448014/diff/1/PRESUBMIT_test.py
File PRESUBMIT_test.py (right):

https://codereview.chromium.org/11448014/diff/1/PRESUBMIT_test.py#newcode19
PRESUBMIT_test.py:19: def AddFile(self, f):
I don't think it's necessary.

https://codereview.chromium.org/11448014/diff/1/PRESUBMIT_test.py#newcode231
PRESUBMIT_test.py:231: mock_input_api.AddFile(MockFile('some/path/foo.cc', ''))
mock_input_api.files = [
    MockFile(...),
    ...
]

[enne (OOO), 2012-12-05 19:36:07]

Thanks for all the suggestions.  Done.

[M-A Ruel, 2012-12-05 19:39:22]

lgtm, thanks.

https://codereview.chromium.org/11448014/diff/5001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/11448014/diff/5001/PRESUBMIT.py#newcode757
PRESUBMIT.py:757: problems = [f.LocalPath() for f in input_api.AffectedFiles()
In theory, you should put this one at +4 too on next line

[enne (OOO), 2012-12-05 19:46:44]

https://codereview.chromium.org/11448014/diff/5001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/11448014/diff/5001/PRESUBMIT.py#newcode757
PRESUBMIT.py:757: problems = [f.LocalPath() for f in input_api.AffectedFiles()
On 2012/12/05 19:39:22, Marc-Antoine Ruel wrote:
> In theory, you should put this one at +4 too on next line

Oh? Are you suggesting to linebreak after the bracket? (Although in that case,
wouldn't it just be +2 indent?)

I'm happy to change it to whatever you want, I just don't quite follow. 
\noideadog{enne formatting Python code}

[M-A Ruel, 2012-12-05 19:51:08]

Add NOTRY=true to expedite it.

https://codereview.chromium.org/11448014/diff/5001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/11448014/diff/5001/PRESUBMIT.py#newcode757
PRESUBMIT.py:757: problems = [f.LocalPath() for f in input_api.AffectedFiles()
On 2012/12/05 19:46:44, enne wrote:
> On 2012/12/05 19:39:22, Marc-Antoine Ruel wrote:
> > In theory, you should put this one at +4 too on next line
> 
> Oh? Are you suggesting to linebreak after the bracket? (Although in that case,
> wouldn't it just be +2 indent?)

Actually, you are right it'd be +2, don't bother.

[commit-bot: I haz the power, 2012-12-05 19:54:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/11448014/5001

[commit-bot: I haz the power, 2012-12-05 19:56:51]

Change committed as 171287