Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2291)

Unified Diff: chrome/browser/search_engines/search_terms_data.cc

Issue 11448005: Add Android-specific parameters to search_engines/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding sourceid changes Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/search_terms_data.cc
diff --git a/chrome/browser/search_engines/search_terms_data.cc b/chrome/browser/search_engines/search_terms_data.cc
index b623fefeb5a7e84d09237ca3ca03f0a1906eb9b8..20d168243f06a217f79f48ccac2767c78d019d5a 100644
--- a/chrome/browser/search_engines/search_terms_data.cc
+++ b/chrome/browser/search_engines/search_terms_data.cc
@@ -5,7 +5,6 @@
#include "chrome/browser/search_engines/search_terms_data.h"
#include "base/logging.h"
-#include "base/metrics/field_trial.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/google/google_url_tracker.h"
#include "chrome/browser/google/google_util.h"
@@ -16,7 +15,6 @@
#include "googleurl/src/gurl.h"
#if defined(ENABLE_RLZ)
-#include "chrome/browser/google/google_util.h"
#include "chrome/browser/rlz/rlz.h"
#endif
@@ -56,11 +54,13 @@ std::string SearchTermsData::GetApplicationLocale() const {
return "en";
}
-#if defined(ENABLE_RLZ)
string16 SearchTermsData::GetRlzParameterValue() const {
return string16();
}
-#endif
+
+std::string SearchTermsData::GetSearchClient() const {
+ return std::string();
+}
std::string SearchTermsData::InstantEnabledParam() const {
return std::string();
@@ -90,11 +90,12 @@ std::string UIThreadSearchTermsData::GetApplicationLocale() const {
return g_browser_process->GetApplicationLocale();
}
-#if defined(ENABLE_RLZ)
+#if !defined(OS_ANDROID)
Peter Kasting 2012/12/06 07:02:37 Tiny nit: You might want an "Android implementatio
gone 2012/12/06 20:59:49 Done.
string16 UIThreadSearchTermsData::GetRlzParameterValue() const {
DCHECK(!BrowserThread::IsWellKnownThread(BrowserThread::UI) ||
BrowserThread::CurrentlyOn(BrowserThread::UI));
string16 rlz_string;
+#if defined(ENABLE_RLZ)
// For organic brandcodes do not use rlz at all. Empty brandcode usually
// means a chromium install. This is ok.
std::string brand;
@@ -105,8 +106,15 @@ string16 UIThreadSearchTermsData::GetRlzParameterValue() const {
// search might not send the RLZ data but this is not really a problem.
RLZTracker::GetAccessPointRlz(RLZTracker::CHROME_OMNIBOX, &rlz_string);
}
+#endif
return rlz_string;
}
+
+std::string UIThreadSearchTermsData::GetSearchClient() const {
+ DCHECK(!BrowserThread::IsWellKnownThread(BrowserThread::UI) ||
+ BrowserThread::CurrentlyOn(BrowserThread::UI));
+ return std::string();
+}
#endif
std::string UIThreadSearchTermsData::InstantEnabledParam() const {

Powered by Google App Engine
This is Rietveld 408576698