Issue 11447007: Fix unexpected auxiliary text appearance.

Issue 11447007: Fix unexpected auxiliary text appearance. (Closed)

Created:
8 years ago by Seigo Nonaka

Modified:
7 years, 11 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix unexpected auxiliary text appearance. |visible| value means whole candidate window is visible or not. So should not shown auxiliary text if the window visibility is false. BUG=None TEST=Manually done on lumpy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175721

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Address comments #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -22 lines)			Patch
	M	chrome/browser/chromeos/input_method/input_method_engine_ibus.h	View	1 2 3	1 chunk	+4 lines, -2 lines	0 comments	Download
	M	chrome/browser/chromeos/input_method/input_method_engine_ibus.cc	View	1 2 3	4 chunks	+23 lines, -20 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Zachary Kuznia

lgtm https://codereview.chromium.org/11447007/diff/1004/chrome/browser/chromeos/input_method/input_method_engine_ibus.h File chrome/browser/chromeos/input_method/input_method_engine_ibus.h (right): https://codereview.chromium.org/11447007/diff/1004/chrome/browser/chromeos/input_method/input_method_engine_ibus.h#newcode163 chrome/browser/chromeos/input_method/input_method_engine_ibus.h:163: // The whole window visibility. Indicates whether the ...

7 years, 11 months ago (2013-01-09 04:30:50 UTC) #4

Seigo Nonaka

Thank you for your review! https://codereview.chromium.org/11447007/diff/1004/chrome/browser/chromeos/input_method/input_method_engine_ibus.h File chrome/browser/chromeos/input_method/input_method_engine_ibus.h (right): https://codereview.chromium.org/11447007/diff/1004/chrome/browser/chromeos/input_method/input_method_engine_ibus.h#newcode163 chrome/browser/chromeos/input_method/input_method_engine_ibus.h:163: // The whole window ...

7 years, 11 months ago (2013-01-09 04:55:23 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11447007/10001

7 years, 11 months ago (2013-01-09 04:55:39 UTC) #6

Message was sent while issue was closed.

Change committed as 175721

Expand Messages | Collapse Messages