chrome/browser/extensions/api/omnibox/omnibox_apitest.cc - Issue 11446034: SupportsUserData and manifest handlers for Extension; use them for the Omnibox API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_apitest.cc

Issue 11446034: SupportsUserData and manifest handlers for Extension; use them for the Omnibox API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nit Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/omnibox/omnibox_api.cc ('K') | « chrome/browser/extensions/api/omnibox/omnibox_api_factory.cc ('k') | chrome/browser/extensions/extension_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/omnibox/omnibox_apitest.cc

diff --git a/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc b/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc

index 1ba2f4b2d3c3fb02104d09282f838d679c9e564e..8fb68e9213a4134471d90e922d34aa3d62288c5e 100644

--- a/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc

+++ b/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc

@@ -67,7 +67,7 @@ class OmniboxApiTest : public ExtensionApiTest {

}

};

-IN_PROC_BROWSER_TEST_F(OmniboxApiTest, DISABLED_Basic) {

+IN_PROC_BROWSER_TEST_F(OmniboxApiTest, Basic) {

ASSERT_TRUE(RunExtensionTest("omnibox")) << message_;

// The results depend on the TemplateURLService being loaded. Make sure it is

@@ -182,7 +182,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, DISABLED_Basic) {

// Tests that the autocomplete popup doesn't reopen after accepting input for

// a given query.

// http://crbug.com/88552

-IN_PROC_BROWSER_TEST_F(OmniboxApiTest, DISABLED_PopupStaysClosed) {

+IN_PROC_BROWSER_TEST_F(OmniboxApiTest, PopupStaysClosed) {

ASSERT_TRUE(RunExtensionTest("omnibox")) << message_;

// The results depend on the TemplateURLService being loaded. Make sure it is