Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8029)

Unified Diff: chrome/browser/ui/webui/options/search_engine_manager_handler.cc

Issue 11446034: SupportsUserData and manifest handlers for Extension; use them for the Omnibox API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase + manifestdata Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/search_engine_manager_handler.cc
diff --git a/chrome/browser/ui/webui/options/search_engine_manager_handler.cc b/chrome/browser/ui/webui/options/search_engine_manager_handler.cc
index 8821d61fc109b32e6936e0238e3812d90162bf5e..1827883ee53eb4bf43aeb3f630c5e89c31b60069 100644
--- a/chrome/browser/ui/webui/options/search_engine_manager_handler.cc
+++ b/chrome/browser/ui/webui/options/search_engine_manager_handler.cc
@@ -14,6 +14,7 @@
#include "chrome/browser/search_engines/template_url_service.h"
#include "chrome/browser/ui/search_engines/keyword_editor_controller.h"
#include "chrome/browser/ui/search_engines/template_url_table_model.h"
+#include "chrome/common/extensions/api/omnibox/omnibox_handler.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/url_constants.h"
#include "content/public/browser/web_ui.h"
@@ -144,7 +145,7 @@ void SearchEngineManagerHandler::OnModelChanged() {
const ExtensionSet* extensions = extension_service->extensions();
for (ExtensionSet::const_iterator it = extensions->begin();
it != extensions->end(); ++it) {
- if ((*it)->omnibox_keyword().size() > 0)
+ if (extensions::OmniboxInfo::GetKeyword(*it).size() > 0)
keyword_list.Append(CreateDictionaryForExtension(*(*it)));
}
}
@@ -170,7 +171,8 @@ base::DictionaryValue* SearchEngineManagerHandler::CreateDictionaryForExtension(
base::DictionaryValue* dict = new base::DictionaryValue();
dict->SetString("name", extension.name());
dict->SetString("displayName", extension.name());
- dict->SetString("keyword", extension.omnibox_keyword());
+ dict->SetString("keyword",
+ extensions::OmniboxInfo::GetKeyword(&extension));
GURL icon = extension.GetIconURL(16, ExtensionIconSet::MATCH_BIGGER);
dict->SetString("iconURL", icon.spec());
dict->SetString("url", string16());
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698