chrome/renderer/autofill/password_autofill_manager.cc - Issue 11446028: Ignore autocomplete=off when password manager is saving the generated passwords during account crea…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/autofill/password_autofill_manager.cc

Issue 11446028: Ignore autocomplete=off when password manager is saving the generated passwords during account crea… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix a naming issue. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_unittest.cc ('k') | chrome/renderer/autofill/password_generation_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/autofill/password_autofill_manager.cc

diff --git a/chrome/renderer/autofill/password_autofill_manager.cc b/chrome/renderer/autofill/password_autofill_manager.cc

index 15386163a79c762ee3fcdf070f9ef57dff195630..083f99c7ec32d8be5f3af53a57bbf148d8da4c51 100644

--- a/chrome/renderer/autofill/password_autofill_manager.cc

+++ b/chrome/renderer/autofill/password_autofill_manager.cc

@@ -348,10 +348,6 @@ void PasswordAutofillManager::SendPasswordForms(WebKit::WebFrame* frame,

for (size_t i = 0; i < forms.size(); ++i) {

const WebKit::WebFormElement& form = forms[i];

- // Respect autocomplete=off.

- if (!form.autoComplete())

- continue;

// If requested, ignore non-rendered forms, e.g. those styled with

// display:none.

if (only_visible && !form.hasNonEmptyBoundingBox())