Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1144473003: <webview>: Add JavaScript test for IndexedDB isolation. (Closed)

Created:
5 years, 7 months ago by lazyboy
Modified:
5 years, 7 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

<webview>: Add JavaScript test for IndexedDB isolation. Remove the old and disabled test. Previously we used to run the test partly in cpp and partly in JS. This CL changes the test code to run entirely in JS, requiring less context switches (== faster) and improving readability. BUG=248500, 160361 Test=None, no visible changes. Committed: https://crrev.com/c4ae3ecb1e6d47a891123d44229f4ee5f9a834ac Cr-Commit-Position: refs/heads/master@{#329863}

Patch Set 1 #

Patch Set 2 : cleanup for review #

Patch Set 3 : add missing file #

Total comments: 2

Patch Set 4 : address comments #

Patch Set 5 : comments #

Messages

Total messages: 12 (5 generated)
lazyboy
+Xi for review.
5 years, 7 months ago (2015-05-13 20:41:17 UTC) #2
Xi Han
lgtm https://chromiumcodereview.appspot.com/1144473003/diff/40001/chrome/test/data/extensions/platform_apps/web_view/isolation_indexeddb/main.js File chrome/test/data/extensions/platform_apps/web_view/isolation_indexeddb/main.js (right): https://chromiumcodereview.appspot.com/1144473003/diff/40001/chrome/test/data/extensions/platform_apps/web_view/isolation_indexeddb/main.js#newcode25 chrome/test/data/extensions/platform_apps/web_view/isolation_indexeddb/main.js:25: Guest.prototype.runIDBSteps = function( nit: add comment of this ...
5 years, 7 months ago (2015-05-14 15:35:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144473003/40001
5 years, 7 months ago (2015-05-14 15:36:15 UTC) #5
lazyboy
https://chromiumcodereview.appspot.com/1144473003/diff/40001/chrome/test/data/extensions/platform_apps/web_view/isolation_indexeddb/main.js File chrome/test/data/extensions/platform_apps/web_view/isolation_indexeddb/main.js (right): https://chromiumcodereview.appspot.com/1144473003/diff/40001/chrome/test/data/extensions/platform_apps/web_view/isolation_indexeddb/main.js#newcode25 chrome/test/data/extensions/platform_apps/web_view/isolation_indexeddb/main.js:25: Guest.prototype.runIDBSteps = function( On 2015/05/14 15:35:03, Xi Han wrote: ...
5 years, 7 months ago (2015-05-14 15:50:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144473003/80001
5 years, 7 months ago (2015-05-14 17:06:13 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-14 17:11:42 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 17:12:36 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c4ae3ecb1e6d47a891123d44229f4ee5f9a834ac
Cr-Commit-Position: refs/heads/master@{#329863}

Powered by Google App Engine
This is Rietveld 408576698