Issue 11444024: Clarify the use of the term "Document" in gdata_wapi_operations.h.

Issue 11444024: Clarify the use of the term "Document" in gdata_wapi_operations.h. (Closed)

Created:
8 years ago by kinaba

Modified:
8 years ago

Reviewers:
satorux1

CC:
chromium-reviews, achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clarify the use of the term "Document" in gdata_wapi_operations.h. Resource = Regular File + Hosted Document + Directory. GetDoucmentEntryOperation and DeleteDocumentOperation is actually used for any resources. CopyDocumentOperation only works for hosted documents, so making it clearer. BUG=164538, 164090 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171489

Patch Set 1 #

Patch Set 2 : gd:deleted #

Patch Set 3 : Fix for test. #

Patch Set 4 : Comment on DeleteResourceOperation. #

Total comments: 5

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -53 lines)			Patch
M	chrome/browser/google_apis/gdata_wapi_operations.h	View	1 2 3	7 chunks	+23 lines, -18 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_operations.cc	View	1	7 chunks	+20 lines, -19 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_operations_unittest.cc	View	1 2	4 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_service.cc	View	1	3 chunks	+8 lines, -8 lines	5 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

satorux1

LGTM. Thanks! https://codereview.chromium.org/11444024/diff/4002/chrome/browser/google_apis/gdata_wapi_service.cc File chrome/browser/google_apis/gdata_wapi_service.cc (right): https://codereview.chromium.org/11444024/diff/4002/chrome/browser/google_apis/gdata_wapi_service.cc#newcode137 chrome/browser/google_apis/gdata_wapi_service.cc:137: void GDataWapiService::GetDocuments( oh this also has to ...

8 years ago (2012-12-06 06:04:53 UTC) #2

kinaba

> chrome/browser/google_apis/gdata_wapi_service.cc:137: void > GDataWapiService::GetDocuments( > oh this also has to be renamed... but probably ...

8 years ago (2012-12-06 06:38:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/11444024/4002

8 years ago (2012-12-06 06:38:50 UTC) #4

Message was sent while issue was closed.

Change committed as 171489

Expand Messages | Collapse Messages