Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 11443020: Replaced vector with set for current_jobs_. (Closed)

Created:
8 years ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years ago
Reviewers:
gene
CC:
chromium-reviews
Visibility:
Public.

Description

Replaced vector with set for current_jobs_. This simplify code and make sure that jobs are unique. BUG=154485, 161569 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171447

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -41 lines) Patch
M chrome/browser/printing/print_job_manager.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_job_manager.cc View 1 2 chunks +15 lines, -40 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
8 years ago (2012-12-05 21:41:23 UTC) #1
gene
https://codereview.chromium.org/11443020/diff/1/chrome/browser/printing/print_job_manager.cc File chrome/browser/printing/print_job_manager.cc (right): https://codereview.chromium.org/11443020/diff/1/chrome/browser/printing/print_job_manager.cc#newcode115 chrome/browser/printing/print_job_manager.cc:115: DCHECK(std::count(current_jobs_.begin(), I think this check makes more sense in ...
8 years ago (2012-12-05 21:52:31 UTC) #2
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/11443020/diff/1/chrome/browser/printing/print_job_manager.cc File chrome/browser/printing/print_job_manager.cc (right): https://codereview.chromium.org/11443020/diff/1/chrome/browser/printing/print_job_manager.cc#newcode115 chrome/browser/printing/print_job_manager.cc:115: DCHECK(std::count(current_jobs_.begin(), On 2012/12/05 21:52:31, gene wrote: > I think ...
8 years ago (2012-12-05 23:27:42 UTC) #3
gene
lgtm
8 years ago (2012-12-05 23:33:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/11443020/3002
8 years ago (2012-12-05 23:36:08 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years ago (2012-12-06 06:14:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/11443020/3002
8 years ago (2012-12-06 06:16:58 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-06 07:56:06 UTC) #8
Message was sent while issue was closed.
Change committed as 171447

Powered by Google App Engine
This is Rietveld 408576698