Show app list items which open in chrome with a tab overlay.

Show app list items which open in chrome with a tab overlay.

This change affects chrome os and windows implementations of the app list. Chrome, web store, and v1 apps like google search are displayed with a tab overlay.

BUG=159859
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173423

[benwells, 2012-12-12 06:08:06]

sky: chrome/app, gypi change and anything else you want to look at
xiyuan: app_list

[xiyuan, 2012-12-12 17:12:43]

https://codereview.chromium.org/11442044/diff/1/chrome/browser/ui/app_list/ex...
File chrome/browser/ui/app_list/extension_app_item.cc (right):

https://codereview.chromium.org/11442044/diff/1/chrome/browser/ui/app_list/ex...
chrome/browser/ui/app_list/extension_app_item.cc:251: ui::SCALE_FACTOR_100P,
false);
This does not work properly on HiDPI. I think you need to create the badged
image using CanvasImageSource. One example of such use is BadgeImageSource in
chrome/browser/ui/views/toolbar_view.cc

https://cs.corp.google.com/#chrome/src/chrome/browser/ui/views/toolbar_view.c...

https://codereview.chromium.org/11442044/diff/1/chrome/browser/ui/app_list/ex...
chrome/browser/ui/app_list/extension_app_item.cc:256: 0, 0);
Should we draw the tab first since it is bigger and more like a frame for the
icon?

[benwells, 2012-12-13 06:38:27]

https://codereview.chromium.org/11442044/diff/1/chrome/browser/ui/app_list/ex...
File chrome/browser/ui/app_list/extension_app_item.cc (right):

https://codereview.chromium.org/11442044/diff/1/chrome/browser/ui/app_list/ex...
chrome/browser/ui/app_list/extension_app_item.cc:251: ui::SCALE_FACTOR_100P,
false);
On 2012/12/12 17:12:43, xiyuan wrote:
> This does not work properly on HiDPI. I think you need to create the badged
> image using CanvasImageSource. One example of such use is BadgeImageSource in
> chrome/browser/ui/views/toolbar_view.cc
> 
>
https://cs.corp.google.com/#chrome/src/chrome/browser/ui/views/toolbar_view.c...

Yep, thanks for that. For now I'm just going to have this on Windows to get some
feedback. I've been a bit worried about this suddenly changing ChromeOS just
before M25 branch.

If this design is good I can update to support HiDPI before enabling for
ChromeOS. It looks pretty simple (thanks for the link).

https://codereview.chromium.org/11442044/diff/1/chrome/browser/ui/app_list/ex...
chrome/browser/ui/app_list/extension_app_item.cc:256: 0, 0);
On 2012/12/12 17:12:43, xiyuan wrote:
> Should we draw the tab first since it is bigger and more like a frame for the
> icon?

I've switched it around. It does make a slight difference as  I don't think the
inside of tab is completely transparent. By drawing the icon last it doesn't get
faded out by this transparency.

[xiyuan, 2012-12-13 17:26:54]

LGTM

https://codereview.chromium.org/11442044/diff/1/chrome/browser/ui/app_list/ex...
File chrome/browser/ui/app_list/extension_app_item.cc (right):

https://codereview.chromium.org/11442044/diff/1/chrome/browser/ui/app_list/ex...
chrome/browser/ui/app_list/extension_app_item.cc:251: ui::SCALE_FACTOR_100P,
false);
On 2012/12/13 06:38:27, benwells wrote:
> On 2012/12/12 17:12:43, xiyuan wrote:
> > This does not work properly on HiDPI. I think you need to create the badged
> > image using CanvasImageSource. One example of such use is BadgeImageSource
in
> > chrome/browser/ui/views/toolbar_view.cc
> > 
> >
>
https://cs.corp.google.com/#chrome/src/chrome/browser/ui/views/toolbar_view.c...
> 
> Yep, thanks for that. For now I'm just going to have this on Windows to get
some
> feedback. I've been a bit worried about this suddenly changing ChromeOS just
> before M25 branch.
> 
> If this design is good I can update to support HiDPI before enabling for
> ChromeOS. It looks pretty simple (thanks for the link).

CanvasImageSource is cross platform and we should use that on Windows too. Let's
at least put a TODO here.

[sky, 2012-12-13 20:16:05]

LGTM

[commit-bot: I haz the power, 2012-12-13 23:25:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/11442044/6001

[commit-bot: I haz the power, 2012-12-13 23:25:43]

Presubmit check for 11442044-6001 failed and returned exit status 1.

/b/commit-queue/workdir/chromium/chrome/app/theme/default_100_percent/app_list_tab_overlay.png:
Must not have executable bit set
/b/commit-queue/workdir/chromium/chrome/app/theme/default_200_percent/app_list_tab_overlay.png:
Must not have executable bit set
Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1259, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1107, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1024, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 19, in CheckChangeOnCommit
  File "<string>", line 43, in _CommonChecks
  File
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
line 85, in RunChecks
    base_dimensions = ImageSize(base_image)
  File
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
line 47, in ImageSize
    assert data[:8] == '\x89PNG\r\n\x1A\n' and data[12:16] == 'IHDR'
AssertionError

[commit-bot: I haz the power, 2012-12-17 04:49:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/11442044/12001

[commit-bot: I haz the power, 2012-12-17 06:41:34]

Change committed as 173423